Remove > 0 check (tautology)

Author: AlyElashram

libc/src/string/memccpy.cpp

@@ -18,7 +18,7 @@ namespace LIBC_NAMESPACE_DECL {
 LLVM_LIBC_FUNCTION(void *, memccpy,
                    (void *__restrict dest, const void *__restrict src, int c,
                     size_t count)) {
-  if (c > 0) {
+  if (c) {
     LIBC_CRASH_ON_NULLPTR(dest);
     LIBC_CRASH_ON_NULLPTR(src);
   }

libc/src/string/memchr.cpp

@@ -18,9 +18,8 @@ namespace LIBC_NAMESPACE_DECL {
 
 // TODO: Look at performance benefits of comparing words.
 LLVM_LIBC_FUNCTION(void *, memchr, (const void *src, int c, size_t n)) {
-  if (n > 0) {
+  if (n)
     LIBC_CRASH_ON_NULLPTR(src);
-  }
   return internal::find_first_character(
       reinterpret_cast<const unsigned char *>(src),
       static_cast<unsigned char>(c), n);

libc/src/string/memcmp.cpp

@@ -17,7 +17,7 @@ namespace LIBC_NAMESPACE_DECL {
 
 LLVM_LIBC_FUNCTION(int, memcmp,
                    (const void *lhs, const void *rhs, size_t count)) {
-  if (count > 0) {
+  if (count) {
     LIBC_CRASH_ON_NULLPTR(lhs);
     LIBC_CRASH_ON_NULLPTR(rhs);
   }

libc/src/string/memcpy.cpp

@@ -17,7 +17,7 @@ namespace LIBC_NAMESPACE_DECL {
 LLVM_LIBC_FUNCTION(void *, memcpy,
                    (void *__restrict dst, const void *__restrict src,
                     size_t size)) {
-  if (size > 0) {
+  if (size) {
     LIBC_CRASH_ON_NULLPTR(dst);
     LIBC_CRASH_ON_NULLPTR(src);
   }

libc/src/string/memmove.cpp

@@ -17,7 +17,7 @@ namespace LIBC_NAMESPACE_DECL {
 
 LLVM_LIBC_FUNCTION(void *, memmove,
                    (void *dst, const void *src, size_t count)) {
-  if (count > 0) {
+  if (count) {
     LIBC_CRASH_ON_NULLPTR(dst);
     LIBC_CRASH_ON_NULLPTR(src);
   }

libc/src/string/strncat.cpp

@@ -19,7 +19,7 @@ namespace LIBC_NAMESPACE_DECL {
 LLVM_LIBC_FUNCTION(char *, strncat,
                    (char *__restrict dest, const char *__restrict src,
                     size_t count)) {
-  if (count > 0) {
+  if (count) {
     LIBC_CRASH_ON_NULLPTR(dest);
     LIBC_CRASH_ON_NULLPTR(src);
   }

libc/src/string/strncmp.cpp

@@ -19,7 +19,7 @@ namespace LIBC_NAMESPACE_DECL {
 
 LLVM_LIBC_FUNCTION(int, strncmp,
                    (const char *left, const char *right, size_t n)) {
-  if (n > 0) {
+  if (n) {
     LIBC_CRASH_ON_NULLPTR(left);
     LIBC_CRASH_ON_NULLPTR(right);
   }

libc/src/string/strncpy.cpp

@@ -18,7 +18,7 @@ namespace LIBC_NAMESPACE_DECL {
 LLVM_LIBC_FUNCTION(char *, strncpy,
                    (char *__restrict dest, const char *__restrict src,
                     size_t n)) {
-  if (n > 0) {
+  if (n) {
     LIBC_CRASH_ON_NULLPTR(dest);
     LIBC_CRASH_ON_NULLPTR(src);
   }

libc/src/string/strsep.cpp

@@ -17,9 +17,9 @@ namespace LIBC_NAMESPACE_DECL {
 LLVM_LIBC_FUNCTION(char *, strsep,
                    (char **__restrict stringp, const char *__restrict delim)) {
   LIBC_CRASH_ON_NULLPTR(stringp);
-  LIBC_CRASH_ON_NULLPTR(delim);
   if (!*stringp)
     return nullptr;
+  LIBC_CRASH_ON_NULLPTR(delim);
   return internal::string_token<false>(*stringp, delim, stringp);
 }