Skip to content

Commit bce48c8

Browse files
[lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (#159606)
Based on testing on processors that use pointer metadata, and with all the work done to delay calls to FixDataAddress, this is no longer necessary. Note that, with debugserver in particular, this is an NFC change: the code path here is for frame zero, and debugserver will strip metadata when reading fp from frame zero anyway.
1 parent 1eb575d commit bce48c8

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lldb/source/Target/RegisterContextUnwind.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2223,9 +2223,6 @@ bool RegisterContextUnwind::ReadGPRValue(lldb::RegisterKind register_kind,
22232223
if (generic_regnum == LLDB_REGNUM_GENERIC_PC ||
22242224
generic_regnum == LLDB_REGNUM_GENERIC_RA)
22252225
value = abi_sp->FixCodeAddress(value);
2226-
if (generic_regnum == LLDB_REGNUM_GENERIC_SP ||
2227-
generic_regnum == LLDB_REGNUM_GENERIC_FP)
2228-
value = abi_sp->FixDataAddress(value);
22292226
}
22302227
return true;
22312228
}

0 commit comments

Comments
 (0)