test

Created using spr 1.3.7

Author: fmayer

clang/lib/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp

@@ -296,6 +296,8 @@ static void transferStatusOkCall(const CXXMemberCallExpr *Expr,
 static void transferStatusUpdateCall(const CXXMemberCallExpr *Expr,
                                      const MatchFinder::MatchResult &,
                                      LatticeTransferState &State) {
+  // S.Update(OtherS) sets S to the error code of OtherS if it is OK,
+  // otherwise does nothing.
   assert(Expr->getNumArgs() == 1);
   auto *Arg = Expr->getArg(0);
   RecordStorageLocation *ArgRecord =

clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp

@@ -2494,6 +2494,19 @@ TEST_P(UncheckedStatusOrAccessModelTest, UnwrapValueWithStatusPtrCheck) {
   )cc");
 }
 
+TEST_P(UncheckedStatusOrAccessModelTest, UnwrapValueWithMovedStatus) {
+  ExpectDiagnosticsFor(R"cc(
+#include "unchecked_statusor_access_test_defs.h"
+
+    void target(STATUSOR_INT sor) {
+      if (std::move(sor.status()).ok())
+        sor.value();
+      else
+        sor.value();  // [[unsafe]]
+    }
+  )cc");
+}
+
 TEST_P(UncheckedStatusOrAccessModelTest, MembersUsedInsideStatus) {
   ExpectDiagnosticsFor(R"cc(
     namespace absl {