Skip to content

Commit be9173c

Browse files
committed
self-review: use << operator instead of redefining switch behaviour
1 parent 3da3df5 commit be9173c

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

llvm/lib/Frontend/HLSL/HLSLRootSignature.cpp

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -163,25 +163,6 @@ void dumpRootElements(raw_ostream &OS, ArrayRef<RootElement> Elements) {
163163
OS << "}";
164164
}
165165

166-
static MDString *ClauseTypeToName(LLVMContext &Ctx, ClauseType Type) {
167-
StringRef Name;
168-
switch (Type) {
169-
case ClauseType::CBuffer:
170-
Name = "CBV";
171-
break;
172-
case ClauseType::SRV:
173-
Name = "SRV";
174-
break;
175-
case ClauseType::UAV:
176-
Name = "UAV";
177-
break;
178-
case ClauseType::Sampler:
179-
Name = "Sampler";
180-
break;
181-
}
182-
return MDString::get(Ctx, Name);
183-
}
184-
185166
MDNode *MetadataBuilder::BuildRootSignature() {
186167
for (const RootElement &Element : Elements) {
187168
MDNode *ElementMD = nullptr;
@@ -220,9 +201,12 @@ MDNode *MetadataBuilder::BuildDescriptorTable(const DescriptorTable &Table) {
220201
MDNode *MetadataBuilder::BuildDescriptorTableClause(
221202
const DescriptorTableClause &Clause) {
222203
IRBuilder<> B(Ctx);
204+
std::string Name;
205+
llvm::raw_string_ostream OS(Name);
206+
OS << Clause.Type;
223207
return MDNode::get(
224208
Ctx, {
225-
ClauseTypeToName(Ctx, Clause.Type),
209+
MDString::get(Ctx, OS.str()),
226210
ConstantAsMetadata::get(B.getInt32(Clause.NumDescriptors)),
227211
ConstantAsMetadata::get(B.getInt32(Clause.Reg.Number)),
228212
ConstantAsMetadata::get(B.getInt32(Clause.Space)),

0 commit comments

Comments
 (0)