fix

Author: HerrCai0907

clang/lib/Analysis/ExprMutationAnalyzer.cpp

@@ -13,7 +13,6 @@
 #include "clang/ASTMatchers/ASTMatchers.h"
 #include "clang/ASTMatchers/ASTMatchersMacros.h"
 #include "llvm/ADT/STLExtras.h"
-#include "llvm/Support/Casting.h"
 
 namespace clang {
 using namespace ast_matchers;
@@ -116,10 +115,14 @@ AST_MATCHER_P(Stmt, canResolveToExpr, const Stmt *, Inner) {
   return canExprResolveTo(Exp, Target);
 }
 
+// use class member to store data can reduce stack usage to avoid stack overflow
+// when recursive call.
 class ExprPointeeResolve {
   const Expr *T;
 
   bool resolveExpr(const Expr *E) {
+    if (E == nullptr)
+      return false;
     if (E == T)
       return true;
 

clang/unittests/Analysis/ExprMutationAnalyzerTest.cpp

@@ -1779,7 +1779,7 @@ TEST(ExprMutationAnalyzerTest, PointeeMutatedByPassAsArgumentInConstruct) {
 TEST(ExprMutationAnalyzerTest,
      PointeeMutatedByPassAsArgumentInTemplateConstruct) {
   const std::string Code = "template<class T> void f() { int *x; new T(x); }";
-  auto AST = buildASTFromCodeWithArgs(Code, {});
+  auto AST = buildASTFromCodeWithArgs(Code, {"-fno-delayed-template-parsing"});
   auto Results =
       match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());
   EXPECT_TRUE(isPointeeMutated(Results, AST.get()));
@@ -1793,7 +1793,8 @@ TEST(ExprMutationAnalyzerTest, PointeeMutatedByPassAsArgumentInInitList) {
         "struct initializer_list{ T const* begin; T const* end; };"
         "}"
         "void f() { int *x; std::initializer_list<int*> a{x, x, x}; }";
-    auto AST = buildASTFromCodeWithArgs(Code, {});
+    auto AST =
+        buildASTFromCodeWithArgs(Code, {"-fno-delayed-template-parsing"});
     auto Results =
         match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());
     EXPECT_TRUE(isPointeeMutated(Results, AST.get()));
@@ -1942,4 +1943,16 @@ TEST(ExprMutationAnalyzerTest, PointeeMutatedByPointerArithmeticSubElement) {
   EXPECT_TRUE(isPointeeMutated(Results, AST.get()));
 }
 
+TEST(ExprMutationAnalyzerTest, PointeeMutatedByConditionOperator) {
+  const std::string Code = R"(
+      void f() {
+        int* x;
+        int* y = 1 ? nullptr : x;
+      })";
+  auto AST = buildASTFromCodeWithArgs(Code, {"-Wno-everything"});
+  auto Results =
+      match(withEnclosingCompound(declRefTo("x")), AST->getASTContext());
+  EXPECT_TRUE(isPointeeMutated(Results, AST.get()));
+}
+
 } // namespace clang