Skip to content

Commit bf2c756

Browse files
author
Tom Yang
committed
remove TODO comment
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
1 parent fa605ef commit bf2c756

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "lldb/Utility/Stream.h"
2323
#include "lldb/Utility/Timer.h"
2424
#include "lldb/lldb-private-enumerations.h"
25-
#include "llvm/Support/FormatVariadic.h"
2625
#include "llvm/Support/ThreadPool.h"
2726
#include <atomic>
2827
#include <optional>
@@ -33,11 +32,6 @@ using namespace lldb_private::plugin::dwarf;
3332
using namespace llvm::dwarf;
3433

3534
void ManualDWARFIndex::Index() {
36-
// TODO(toyang): wrapping it in the call_once isn't really thread-safe either.
37-
// Though, if index callers always call index() before any read/write
38-
// operation (and would therefore wait here), maybe it's ok?
39-
// TODO(toyang): we wrap this logic in the call_once, but maybe it's better if
40-
// it's a separate function that we call instead?
4135
std::call_once(m_indexed_flag, [this]() {
4236
ElapsedTime elapsed(m_index_time);
4337
LLDB_SCOPED_TIMERF("%p", static_cast<void *>(m_dwarf));

0 commit comments

Comments
 (0)