No NOLINT fix for Error Diagnostic

Author: chomosuke

clang-tools-extra/clangd/ParsedAST.cpp

@@ -405,13 +405,12 @@ filterFastTidyChecks(const tidy::ClangTidyCheckFactories &All,
 std::vector<Fix>
 clangTidyNoLintFixes(const clang::tidy::ClangTidyContext &CTContext,
                      const clang::Diagnostic &Info, const Diag &Diag) {
-  auto RuleName = CTContext.getCheckName(Info.getID());
-  if (RuleName.empty()) {
-    return {};
-  }
-  if (!Diag.InsideMainFile) {
+  auto RuleName = CTContext.getCheckName(Diag.ID);
+  if (RuleName.empty() || Diag.Severity >= DiagnosticsEngine::Error ||
+      !Diag.InsideMainFile) {
     return {};
   }
+
   auto &SrcMgr = Info.getSourceManager();
   auto &DiagLoc = Info.getLocation();