simplify

Author: denzor200

clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp

@@ -35,16 +35,7 @@ static bool assignsToBoolean(const BinaryOperator *BinOp, ASTContext *AC) {
   auto Parents = AC->getParents(*BinOp);
 
   for (const auto &Parent : Parents) {
-    const auto *ParentNoParen = ignoreParensTowardsTheRoot(&Parent, AC);
-    // Special handling for `template<bool bb=true|1>` cases
-    if (const auto *D = ParentNoParen->get<Decl>()) {
-      if (const auto *NTTPD = dyn_cast<NonTypeTemplateParmDecl>(D)) {
-        if (NTTPD->getType().getDesugaredType(*AC)->isBooleanType())
-          return true;
-      }
-    }
-
-    if (const auto *S = ParentNoParen->get<Stmt>()) {
+    if (const auto *S = ignoreParensTowardsTheRoot(&Parent, AC)->get<Stmt>()) {
       if (const auto *ICE = dyn_cast<ImplicitCastExpr>(S)) {
         if (ICE->getType().getDesugaredType(*AC)->isBooleanType())
           return true;

clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-not-only-bool-operand.cpp

@@ -11,9 +11,8 @@ void general(unsigned flags, bool value) {
 
 void take(bool value) {}
 
-template<bool bb = true | 1>
-// CHECK-MESSAGES: :[[@LINE-1]]:25: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
-// CHECK-FIXES: template<bool bb = true || 1>
+// FIXME: implement `template<bool bb=true|1>` cases
+
 void assign_to_boolean(unsigned flags, bool value) {
     struct A { bool a = true | 1; };
     // CHECK-MESSAGES: :[[@LINE-1]]:30: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
@@ -50,9 +49,6 @@ void assign_to_boolean(unsigned flags, bool value) {
     // CHECK-FIXES: result = (flags << 1) || (flags << 2) || (flags << 4) || value;
 }
 
-template<bool bb = (true | 1)>
-// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
-// CHECK-FIXES: template<bool bb = (true || 1)>
 void assign_to_boolean_parens(unsigned flags, bool value) {
     struct A { bool a = (true | 1); };
     // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
@@ -89,9 +85,6 @@ void assign_to_boolean_parens(unsigned flags, bool value) {
     // CHECK-FIXES: result = ((flags << 1) || (flags << 2) || (flags << 4) || value);
 }
 
-template<bool bb = ((true | 1))>
-// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
-// CHECK-FIXES: template<bool bb = ((true || 1))>
 void assign_to_boolean_parens2(unsigned flags, bool value) {
     struct A { bool a = ((true | 1)); };
     // CHECK-MESSAGES: :[[@LINE-1]]:32: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
@@ -129,9 +122,6 @@ void assign_to_boolean_parens2(unsigned flags, bool value) {
 }
 
 // functional cast
-template<bool bb = bool(true | 1)>
-// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
-// CHECK-FIXES: template<bool bb = bool(true || 1)>
 void assign_to_boolean_fcast(unsigned flags, bool value) {
     struct A { bool a = bool(true | 1); };
     // CHECK-MESSAGES: :[[@LINE-1]]:35: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
@@ -169,9 +159,6 @@ void assign_to_boolean_fcast(unsigned flags, bool value) {
 }
 
 // C-style cast
-template<bool bb = (bool)(true | 1)>
-// CHECK-MESSAGES: :[[@LINE-1]]:32: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
-// CHECK-FIXES: template<bool bb = (bool)(true || 1)>
 void assign_to_boolean_ccast(unsigned flags, bool value) {
     struct A { bool a = (bool)(true | 1); };
     // CHECK-MESSAGES: :[[@LINE-1]]:37: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
@@ -209,9 +196,6 @@ void assign_to_boolean_ccast(unsigned flags, bool value) {
 }
 
 // static_cast
-template<bool bb = static_cast<bool>(true | 1)>
-// CHECK-MESSAGES: :[[@LINE-1]]:43: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]
-// CHECK-FIXES: template<bool bb = static_cast<bool>(true || 1)>
 void assign_to_boolean_scast(unsigned flags, bool value) {
     struct A { bool a = static_cast<bool>(true | 1); };
     // CHECK-MESSAGES: :[[@LINE-1]]:48: warning: use logical operator '||' for boolean semantics instead of bitwise operator '|' [misc-bool-bitwise-operation]