Skip to content

Commit c0785ea

Browse files
authored
[lldb] Fix plugin test to not rely on enabled targets (#148956)
The plugins completion test was checking completions for the abi plugins. But the available abi plugins will depend on which [targets](https://github.com/llvm/llvm-project/blob/42d2ae1034b287eb60563c370dbf52c59b66db20/lldb/source/Plugins/ABI/CMakeLists.txt#L7) are enabled in the cmake build configuration. This PR updates the test to check for the json object file instead which should be enabled on all builds.
1 parent bc187b8 commit c0785ea

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lldb/test/API/commands/plugin/TestPlugin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ def test_completions(self):
8282
)
8383

8484
# A completion for a full namespace should contain the plugins in that namespace.
85-
self.completions_contain("plugin list abi", ["abi.sysv-x86_64"])
86-
self.completions_contain("plugin list abi.", ["abi.sysv-x86_64"])
87-
self.completions_contain("plugin list abi.s", ["abi.sysv-x86_64"])
88-
self.completions_contain("plugin list abi.sysv-x", ["abi.sysv-x86_64"])
85+
self.completions_contain("plugin list object-file", ["object-file.JSON"])
86+
self.completions_contain("plugin list object-file.", ["object-file.JSON"])
87+
self.completions_contain("plugin list object-file.J", ["object-file.JSON"])
88+
self.completions_contain("plugin list object-file.JS", ["object-file.JSON"])
8989

9090
# Check for a completion that is a both a complete namespace and a prefix of
9191
# another namespace. It should return the completions for the plugins in the completed

0 commit comments

Comments
 (0)