address comments

Author: OCHyams

cross-project-tests/debuginfo-tests/dexter/Commands.md

@@ -390,7 +390,7 @@ line this command is found on.
                          triggers.
 
 ### Description
-NOTE: Only supported for DAP based debuggers.
+NOTE: Only supported for DAP-based debuggers.
 
 This command controls stepping behaviour: Tell dexter to set a function
 breakpoint and step through the function after hitting it. Composes well with
@@ -407,7 +407,7 @@ itself (you can may a callstack with multiple targets to step through) and
                          triggers.
 
 ### Description
-NOTE: Only supported for DAP based debuggers.
+NOTE: Only supported for DAP-based debuggers.
 
 This command controls stepping behaviour: Tell dexter to set a breakpoint on
 `from_line`. When it is hit and optionally '(expr) == (values[n])' is true,

cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexContinue.py

@@ -5,18 +5,21 @@
 # See https://llvm.org/LICENSE.txt for license information.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 """A Command that tells dexter to set a breakpoint which, after hitting,
-signals that the debugger shuold 'continue' until another is hit. Continuing
+signals that the debugger should 'continue' until another is hit. Continuing
 out of a function being stepped through with DexStepFunction is well defined:
 stepping will resume in other functions tracked further down the stacktrace.
 
-NOTE: Only supported for DAP based debuggers.
+NOTE: Only supported for DAP-based debuggers.
 """
 
 from dex.command.CommandBase import CommandBase
 
 
 class DexContinue(CommandBase):
     def __init__(self, *args, **kwargs):
+        # DexContinue(*[expr, *values], **from_line[, **to_line, **hit_count])
+
+        # Optional positional args: expr, values.
         if len(args) == 0:
             self.expression = None
             self.values = []
@@ -25,9 +28,17 @@ def __init__(self, *args, **kwargs):
         else:
             self.expression = args[0]
             self.values = [str(arg) for arg in args[1:]]
-        self.from_line = kwargs.pop("from_line", 1)
+
+        # Required keyword arg: from_line.
+        try:
+            self.from_line = kwargs.pop("from_line")
+        except:
+            raise TypeError("Missing from_line argument")
+
+        # Optional conditional args: to_line, hit_count.
         self.to_line = kwargs.pop("to_line", 999999)
         self.hit_count = kwargs.pop("hit_count", None)
+
         if kwargs:
             raise TypeError("unexpected named args: {}".format(", ".join(kwargs)))
         super(DexContinue, self).__init__()

cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexStepFunction.py

@@ -7,7 +7,7 @@
 """A Command that tells dexter to set a function breakpoint and step through
 the function after hitting it.
 
-NOTE: Only supported for DAP based debuggers.
+NOTE: Only supported for DAP-based debuggers.
 """
 
 from dex.command.CommandBase import CommandBase