Address review comments

Signed-off-by: Arvind Sudarsanam <[email protected]>

Author: asudarsa

clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

@@ -942,7 +942,7 @@ Expected<SmallVector<StringRef>> linkAndWrapDeviceFiles(
       return OutputOrErr.takeError();
 
     // Store the offloading image for each linked output file.
-    for (OffloadKind Kind = OFK_FIRST; Kind != OFK_LAST;
+    for (OffloadKind Kind = OFK_OpenMP; Kind != OFK_LAST;
          Kind = static_cast<OffloadKind>((uint16_t)(Kind) << 1)) {
       if ((ActiveOffloadKindMask & Kind) == 0)
         continue;

llvm/include/llvm/Object/OffloadBinary.h

@@ -32,12 +32,11 @@ namespace object {
 /// The producer of the associated offloading image.
 enum OffloadKind : uint16_t {
   OFK_None = 0,
-  OFK_OpenMP = (1 << 1),
-  OFK_FIRST = OFK_OpenMP,
-  OFK_Cuda = (1 << 2),
-  OFK_HIP = (1 << 3),
-  OFK_SYCL = (1 << 4),
-  OFK_LAST = (1 << 5),
+  OFK_OpenMP = (1 << 0),
+  OFK_Cuda = (1 << 1),
+  OFK_HIP = (1 << 2),
+  OFK_SYCL = (1 << 3),
+  OFK_LAST = (1 << 4),
 };
 
 /// The type of contents the offloading image contains.