[libc++] Silent warning related to memcpy of non trivially-copyable data

serge-sans-paille · serge-sans-paille · commit c0c2f025815f · 2024-10-11T08:48:19.000+02:00
diff --git a/libcxx/include/__iterator/aliasing_iterator.h b/libcxx/include/__iterator/aliasing_iterator.h
@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper {
 
     _LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT {
       _Alias __val;
-      __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type));
+      __builtin_memcpy(&__val, static_cast<const void*>(std::__to_address(__base_)), sizeof(value_type));
       return __val;
     }
 
diff --git a/libcxx/include/__memory/uninitialized_algorithms.h b/libcxx/include/__memory/uninitialized_algorithms.h
@@ -638,7 +638,7 @@ __uninitialized_allocator_relocate(_Alloc& __alloc, _Tp* __first, _Tp* __last, _
     __guard.__complete();
     std::__allocator_destroy(__alloc, __first, __last);
   } else {
-    __builtin_memcpy(__result, __first, sizeof(_Tp) * (__last - __first));
+    __builtin_memcpy((void*)__result, (void*)__first, sizeof(_Tp) * (__last - __first));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper {`
`102`	`102`
`103`	`103`	`_LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT {`
`104`	`104`	`_Alias __val;`
`105`		`- __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type));`
	`105`	`+ __builtin_memcpy(&__val, static_cast<const void*>(std::__to_address(__base_)), sizeof(value_type));`
`106`	`106`	`return __val;`
`107`	`107`	`}`
`108`	`108`
Original file line number	Diff line number	Diff line change
`@@ -638,7 +638,7 @@ __uninitialized_allocator_relocate(_Alloc& __alloc, _Tp* __first, _Tp* __last, _`
`638`	`638`	`__guard.__complete();`
`639`	`639`	`std::__allocator_destroy(__alloc, __first, __last);`
`640`	`640`	`} else {`
`641`		`- __builtin_memcpy(__result, __first, sizeof(_Tp) * (__last - __first));`
	`641`	`+ __builtin_memcpy((void)__result, (void)__first, sizeof(_Tp) * (__last - __first));`
`642`	`642`	`}`
`643`	`643`	`}`
`644`	`644`