s/IsAllowedInCoroutines/IgnoreCoroutines/ and invert logic

Author: dmpolukhin

clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp

@@ -51,7 +51,7 @@ UnnecessaryValueParamCheck::UnnecessaryValueParamCheck(
                areDiagsSelfContained()),
       AllowedTypes(
           utils::options::parseStringList(Options.get("AllowedTypes", ""))),
-      IsAllowedInCoroutines(Options.get("IsAllowedInCoroutines", false)) {}
+      IgnoreCoroutines(Options.get("IgnoreCoroutines", true)) {}
 
 void UnnecessaryValueParamCheck::registerMatchers(MatchFinder *Finder) {
   const auto ExpensiveValueParamDecl = parmVarDecl(
@@ -64,9 +64,9 @@ void UnnecessaryValueParamCheck::registerMatchers(MatchFinder *Finder) {
   Finder->addMatcher(
       traverse(
           TK_AsIs,
-          functionDecl(hasBody(IsAllowedInCoroutines
-                                   ? stmt()
-                                   : stmt(unless(coroutineBodyStmt()))),
+          functionDecl(hasBody(IgnoreCoroutines
+                                   ? stmt(unless(coroutineBodyStmt()))
+                                   : stmt()),
                        isDefinition(), unless(isImplicit()),
                        unless(cxxMethodDecl(anyOf(isOverride(), isFinal()))),
                        has(typeLoc(forEach(ExpensiveValueParamDecl))),
@@ -127,7 +127,7 @@ void UnnecessaryValueParamCheck::storeOptions(
   Options.store(Opts, "IncludeStyle", Inserter.getStyle());
   Options.store(Opts, "AllowedTypes",
                 utils::options::serializeStringList(AllowedTypes));
-  Options.store(Opts, "IsAllowedInCoroutines", IsAllowedInCoroutines);
+  Options.store(Opts, "IgnoreCoroutines", IgnoreCoroutines);
 }
 
 void UnnecessaryValueParamCheck::onEndOfTranslationUnit() {

clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.h

@@ -46,7 +46,7 @@ class UnnecessaryValueParamCheck : public ClangTidyCheck {
   ExprMutationAnalyzer::Memoized MutationAnalyzerCache;
   utils::IncludeInserter Inserter;
   const std::vector<StringRef> AllowedTypes;
-  bool IsAllowedInCoroutines;
+  bool IgnoreCoroutines;
 };
 
 } // namespace clang::tidy::performance

clang-tools-extra/docs/ReleaseNotes.rst

@@ -265,7 +265,7 @@ Changes in existing checks
   <clang-tidy/checks/performance/unnecessary-value-param>` check performance by
   tolerating fix-it breaking compilation when functions is used as pointers
   to avoid matching usage of functions within the current compilation unit.
-  Added an option `IsAllowedInCoroutines` with the default value `false` to
+  Added an option `IgnoreCoroutines` with the default value `true` to
   suppress this check for coroutines where passing by reference may be unsafe.
 
 - Improved :doc:`readability-convert-member-functions-to-static

clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-value-param.rst

@@ -75,9 +75,9 @@ Options
    matched against the qualified type name (i.e. ``namespace::Type``),
    otherwise it is matched against only the type name (i.e. ``Type``).
 
-.. option:: IsAllowedInCoroutines
+.. option:: IgnoreCoroutines
 
    A boolean specifying whether the check should suggest passing parameters by
    reference in coroutines. Passing parameters by reference in coroutines may
    not be safe, please see :doc:`cppcoreguidelines-avoid-reference-coroutine-parameters <../cppcoreguidelines/avoid-reference-coroutine-parameters>`
-   for more information. Default is `false`.
+   for more information. Default is `true`.

clang-tools-extra/test/clang-tidy/checkers/performance/unnecessary-value-param-coroutine.cpp

@@ -1,8 +1,8 @@
 // RUN: %check_clang_tidy -std=c++20-or-later %s performance-unnecessary-value-param %t -- -fix-errors
 // RUN: %check_clang_tidy -std=c++20-or-later %s performance-unnecessary-value-param %t -- \
-// RUN:   -config='{CheckOptions: {performance-unnecessary-value-param.IsAllowedInCoroutines: false}}' -fix-errors
+// RUN:   -config='{CheckOptions: {performance-unnecessary-value-param.IgnoreCoroutines: true}}' -fix-errors
 // RUN: %check_clang_tidy -check-suffix=ALLOWED -std=c++20-or-later %s performance-unnecessary-value-param %t -- \
-// RUN:   -config='{CheckOptions: {performance-unnecessary-value-param.IsAllowedInCoroutines: true}}' -fix-errors
+// RUN:   -config='{CheckOptions: {performance-unnecessary-value-param.IgnoreCoroutines: false}}' -fix-errors
 
 namespace std {