Skip to content

Commit c1ae381

Browse files
authored
[RISCV][VLOPT][NFC] Remove outdated FIXME comments related to supported instructions (#156126)
Remove several FIXME comments in `isSupportedInstr` for opcodes that were already implemented. Also moved switch cases for add-carry/sub-borrow instructions together. NFC.
1 parent 62fd332 commit c1ae381

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

llvm/lib/Target/RISCV/RISCVVLOptimizer.cpp

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -900,13 +900,6 @@ static bool isSupportedInstr(const MachineInstr &MI) {
900900
case RISCV::VSEXT_VF4:
901901
case RISCV::VZEXT_VF8:
902902
case RISCV::VSEXT_VF8:
903-
// Vector Integer Add-with-Carry / Subtract-with-Borrow Instructions
904-
// FIXME: Add support
905-
case RISCV::VMADC_VV:
906-
case RISCV::VMADC_VI:
907-
case RISCV::VMADC_VX:
908-
case RISCV::VMSBC_VV:
909-
case RISCV::VMSBC_VX:
910903
// Vector Narrowing Integer Right Shift Instructions
911904
case RISCV::VNSRL_WX:
912905
case RISCV::VNSRL_WI:
@@ -993,6 +986,11 @@ static bool isSupportedInstr(const MachineInstr &MI) {
993986
case RISCV::VSBC_VXM:
994987
case RISCV::VMSBC_VVM:
995988
case RISCV::VMSBC_VXM:
989+
case RISCV::VMADC_VV:
990+
case RISCV::VMADC_VI:
991+
case RISCV::VMADC_VX:
992+
case RISCV::VMSBC_VV:
993+
case RISCV::VMSBC_VX:
996994
// Vector Widening Integer Multiply-Add Instructions
997995
case RISCV::VWMACCU_VV:
998996
case RISCV::VWMACCU_VX:
@@ -1001,10 +999,7 @@ static bool isSupportedInstr(const MachineInstr &MI) {
1001999
case RISCV::VWMACCSU_VV:
10021000
case RISCV::VWMACCSU_VX:
10031001
case RISCV::VWMACCUS_VX:
1004-
// Vector Integer Merge Instructions
1005-
// FIXME: Add support
10061002
// Vector Integer Move Instructions
1007-
// FIXME: Add support
10081003
case RISCV::VMV_V_I:
10091004
case RISCV::VMV_V_X:
10101005
case RISCV::VMV_V_V:

0 commit comments

Comments
 (0)