Skip to content

Commit c1d2dbc

Browse files
Tweak module.modulemap.in per @ldionne's review comments
1 parent 55d7179 commit c1d2dbc

File tree

1 file changed

+20
-25
lines changed

1 file changed

+20
-25
lines changed

libcxx/include/module.modulemap.in

Lines changed: 20 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,19 @@ module std_config [system] {
1414
}
1515

1616
module std_core [system] {
17-
// TODO: Investigate whether we should bring the whole <concepts> here.
18-
module concepts_core {
17+
module concepts {
1918
module arithmetic { header "__concepts/arithmetic.h" }
2019
module assignable { header "__concepts/assignable.h" }
2120
module boolean_testable { header "__concepts/boolean_testable.h" }
2221
module class_or_enum { header "__concepts/class_or_enum.h" }
2322
module common_reference_with { header "__concepts/common_reference_with.h" }
23+
module common_with { header "__concepts/common_with.h" }
2424
module constructible { header "__concepts/constructible.h" }
2525
module convertible_to { header "__concepts/convertible_to.h" }
2626
module copyable { header "__concepts/copyable.h" }
2727
module derived_from { header "__concepts/derived_from.h" }
2828
module destructible { header "__concepts/destructible.h" }
29+
module different_from { header "__concepts/different_from.h" }
2930
module equality_comparable { header "__concepts/equality_comparable.h" }
3031
module invocable { header "__concepts/invocable.h" }
3132
module movable { header "__concepts/movable.h" }
@@ -36,6 +37,9 @@ module std_core [system] {
3637
module semiregular { header "__concepts/semiregular.h" }
3738
module swappable { header "__concepts/swappable.h" }
3839
module totally_ordered { header "__concepts/totally_ordered.h" }
40+
41+
header "concepts"
42+
export *
3943
}
4044

4145
module cstddef {
@@ -54,18 +58,8 @@ module std_core [system] {
5458
export *
5559
}
5660

57-
module get_fwd {
58-
header "__fwd/get.h"
59-
export std_core.fwd.pair
60-
export std_core.fwd.tuple
61-
export std_core.fwd.array
62-
export std_core.fwd.complex
63-
export std_core.fwd.subrange
64-
export std_core.fwd.variant
65-
}
66-
6761
// Only the truly dependency-free parts of __functional are here
68-
module functional_core {
62+
module functional {
6963
module invoke { header "__functional/invoke.h" }
7064
}
7165

@@ -74,14 +68,23 @@ module std_core [system] {
7468
module complex { header "__fwd/complex.h" }
7569
module byte { header "__fwd/byte.h" }
7670
module functional { header "__fwd/functional.h" }
71+
module get {
72+
header "__fwd/get.h"
73+
export std_core.fwd.pair
74+
export std_core.fwd.tuple
75+
export std_core.fwd.array
76+
export std_core.fwd.complex
77+
export std_core.fwd.subrange
78+
export std_core.fwd.variant
79+
}
7780
module pair { header "__fwd/pair.h" }
7881
module subrange { header "__fwd/subrange.h" }
7982
module tuple { header "__fwd/tuple.h" }
8083
module variant { header "__fwd/variant.h" }
8184
}
8285

8386
// Only the truly dependency-free parts of __iterator are here
84-
module iterator_core {
87+
module iterator {
8588
module concepts {
8689
header "__iterator/concepts.h"
8790
export std_core.type_traits.common_reference
@@ -125,13 +128,13 @@ module std_core [system] {
125128
}
126129

127130
// Only the truly dependency-free parts of __memory are here
128-
module memory_core {
131+
module memory {
129132
module addressof { header "__memory/addressof.h" }
130133
module pointer_traits { header "__memory/pointer_traits.h" }
131134
}
132135

133136
// Only the truly dependency-free parts of __tuple are here
134-
module tuple_core {
137+
module tuple {
135138
module tuple_element { header "__tuple/tuple_element.h" }
136139
module tuple_like { header "__tuple/tuple_like.h" }
137140
module tuple_like_no_subrange { header "__tuple/tuple_like_no_subrange.h" }
@@ -530,7 +533,7 @@ module std [system] {
530533
module iter_swap { header "__algorithm/iter_swap.h" }
531534
module iterator_operations {
532535
header "__algorithm/iterator_operations.h"
533-
export std_core.iterator_core.iter_move
536+
export std_core.iterator.iter_move
534537
export std.iterator.advance
535538
export std.iterator.distance
536539
export std.iterator.iter_swap
@@ -1141,14 +1144,6 @@ module std [system] {
11411144
export *
11421145
}
11431146

1144-
module concepts {
1145-
module common_with { header "__concepts/common_with.h" }
1146-
module different_from { header "__concepts/different_from.h" }
1147-
1148-
header "concepts"
1149-
export *
1150-
}
1151-
11521147
module condition_variable {
11531148
module condition_variable { header "__condition_variable/condition_variable.h" }
11541149

0 commit comments

Comments
 (0)