Skip to content

Commit c22eb9a

Browse files
committed
[NFC][LoopIdiom] Add reproducer of wrong memmove transformation
That's precommit test for D107964. Differential Revision: https://reviews.llvm.org/D108537
1 parent d069343 commit c22eb9a

File tree

1 file changed

+47
-0
lines changed

1 file changed

+47
-0
lines changed

llvm/test/Transforms/LoopIdiom/basic.ll

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,6 +1300,53 @@ for.end: ; preds = %for.body, %entry
13001300
ret void
13011301
}
13021302

1303+
;; FIXME: Do not form memmove when load has more than one use.
1304+
define i32 @do_not_form_memmove5(i32* %p) {
1305+
; CHECK-LABEL: @do_not_form_memmove5(
1306+
; CHECK-NEXT: entry:
1307+
; CHECK-NEXT: [[P2:%.*]] = bitcast i32* [[P:%.*]] to i8*
1308+
; CHECK-NEXT: [[SCEVGEP:%.*]] = getelementptr i32, i32* [[P:%.*]], i64 1
1309+
; CHECK-NEXT: [[SCEVGEP1:%.*]] = bitcast i32* [[SCEVGEP]] to i8*
1310+
; CHECK-NEXT: call void @llvm.memmove.p0i8.p0i8.i64(i8* align 4 [[SCEVGEP1]], i8* align 4 [[P2]], i64 60, i1 false)
1311+
; CHECK-NEXT: br label [[FOR_BODY:%.*]]
1312+
; CHECK: for.cond.cleanup:
1313+
; CHECK-NEXT: [[ADD_LCSSA:%.*]] = phi i32 [ [[ADD:%.*]], [[FOR_BODY]] ]
1314+
; CHECK-NEXT: ret i32 [[ADD_LCSSA]]
1315+
; CHECK: for.body:
1316+
; CHECK-NEXT: [[INDEX:%.*]] = phi i32 [ 15, [[ENTRY:%.*]] ], [ [[SUB:%.*]], [[FOR_BODY]] ]
1317+
; CHECK-NEXT: [[SUM:%.*]] = phi i32 [ 0, [[ENTRY]] ], [ [[ADD]], [[FOR_BODY]] ]
1318+
; CHECK-NEXT: [[SUB]] = add nsw i32 [[INDEX]], -1
1319+
; CHECK-NEXT: [[TMP0:%.*]] = zext i32 [[SUB]] to i64
1320+
; CHECK-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds i32, i32* [[P:%.*]], i64 [[TMP0]]
1321+
; CHECK-NEXT: [[TMP1:%.*]] = load i32, i32* [[ARRAYIDX]], align 4
1322+
; CHECK-NEXT: [[IDXPROM:%.*]] = zext i32 [[INDEX]] to i64
1323+
; CHECK-NEXT: [[ARRAYIDX2:%.*]] = getelementptr inbounds i32, i32* [[P:%.*]], i64 [[IDXPROM]]
1324+
; CHECK-NEXT: [[ADD]] = add nsw i32 [[TMP1]], [[SUM:%.*]]
1325+
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[INDEX]], 1
1326+
; CHECK-NEXT: br i1 [[CMP]], label [[FOR_BODY]], label [[FOR_COND_CLEANUP]]
1327+
;
1328+
entry:
1329+
br label %for.body
1330+
1331+
for.cond.cleanup: ; preds = %for.body
1332+
%add.lcssa = phi i32 [ %add, %for.body ]
1333+
ret i32 %add.lcssa
1334+
1335+
for.body: ; preds = %entry, %for.body
1336+
%index = phi i32 [ 15, %entry ], [ %sub, %for.body ]
1337+
%sum = phi i32 [ 0, %entry ], [ %add, %for.body ]
1338+
%sub = add nsw i32 %index, -1
1339+
%0 = zext i32 %sub to i64
1340+
%arrayidx = getelementptr inbounds i32, i32* %p, i64 %0
1341+
%1 = load i32, i32* %arrayidx, align 4
1342+
%idxprom = zext i32 %index to i64
1343+
%arrayidx2 = getelementptr inbounds i32, i32* %p, i64 %idxprom
1344+
store i32 %1, i32* %arrayidx2, align 4
1345+
%add = add nsw i32 %1, %sum
1346+
%cmp = icmp sgt i32 %index, 1
1347+
br i1 %cmp, label %for.body, label %for.cond.cleanup
1348+
}
1349+
13031350
;; Memcpy formation is still preferred over memmove.
13041351
define void @prefer_memcpy_over_memmove(i8* noalias %Src, i8* noalias %Dest, i64 %Size) {
13051352
; CHECK-LABEL: @prefer_memcpy_over_memmove(

0 commit comments

Comments
 (0)