Skip to content

Commit c233322

Browse files
committed
Move interop header include
Comment in Interop.h saying expectation on Windows is including this after pybind11 - going to try the same for nanobind.
1 parent 59a598c commit c233322

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

mlir/include/mlir/Bindings/Python/NanobindAdaptors.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121

2222
#include <cstdint>
2323

24-
#include "mlir-c/Bindings/Python/Interop.h"
2524
#include "mlir-c/Diagnostics.h"
2625
#include "mlir-c/IR.h"
2726
#include "mlir/Bindings/Python/Nanobind.h"
27+
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
2828
#include "llvm/ADT/Twine.h"
2929

3030
// Raw CAPI type casters need to be declared before use, so always include them

mlir/lib/Bindings/Python/IRAffine.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
#include "NanobindUtils.h"
1818
#include "mlir-c/AffineExpr.h"
1919
#include "mlir-c/AffineMap.h"
20-
#include "mlir-c/Bindings/Python/Interop.h"
2120
#include "mlir-c/IntegerSet.h"
2221
#include "mlir/Bindings/Python/Nanobind.h"
22+
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
2323
#include "mlir/Support/LLVM.h"
2424
#include "llvm/ADT/Hashing.h"
2525
#include "llvm/ADT/SmallVector.h"

mlir/lib/Bindings/Python/IRCore.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
#include "Globals.h"
1313
#include "IRModule.h"
1414
#include "NanobindUtils.h"
15-
#include "mlir-c/Bindings/Python/Interop.h"
1615
#include "mlir-c/BuiltinAttributes.h"
1716
#include "mlir-c/Debug.h"
1817
#include "mlir-c/Diagnostics.h"
1918
#include "mlir-c/IR.h"
2019
#include "mlir-c/Support.h"
2120
#include "mlir/Bindings/Python/Nanobind.h"
2221
#include "mlir/Bindings/Python/NanobindAdaptors.h"
22+
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
2323
#include "llvm/ADT/ArrayRef.h"
2424
#include "llvm/ADT/SmallVector.h"
2525

mlir/lib/Bindings/Python/IRModule.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313

1414
#include "Globals.h"
1515
#include "NanobindUtils.h"
16-
#include "mlir-c/Bindings/Python/Interop.h"
1716
#include "mlir-c/Support.h"
1817
#include "mlir/Bindings/Python/Nanobind.h"
18+
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
1919

2020
namespace nb = nanobind;
2121
using namespace mlir;

mlir/lib/Bindings/Python/Pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
#include "Pass.h"
1010

1111
#include "IRModule.h"
12-
#include "mlir-c/Bindings/Python/Interop.h"
1312
#include "mlir-c/Pass.h"
1413
#include "mlir/Bindings/Python/Nanobind.h"
14+
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
1515

1616
namespace nb = nanobind;
1717
using namespace nb::literals;

mlir/lib/Bindings/Python/Rewrite.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
#include "Rewrite.h"
1010

1111
#include "IRModule.h"
12-
#include "mlir-c/Bindings/Python/Interop.h"
1312
#include "mlir-c/Rewrite.h"
1413
#include "mlir/Bindings/Python/Nanobind.h"
14+
#include "mlir-c/Bindings/Python/Interop.h" // This is expected after nanobind.
1515
#include "mlir/Config/mlir-config.h"
1616

1717
namespace nb = nanobind;

0 commit comments

Comments
 (0)