duplicate getDevice() implementation to avoid const_cast

ro-i · ro-i · commit c2464ee43ada · 2025-10-24T09:04:46.000-05:00
diff --git a/offload/plugins-nextgen/common/include/PluginInterface.h b/offload/plugins-nextgen/common/include/PluginInterface.h
@@ -1295,7 +1295,10 @@ struct GenericPluginTy {
     return *Devices[DeviceId];
   }
   const GenericDeviceTy &getDevice(int32_t DeviceId) const {
-    return const_cast<GenericPluginTy *>(this)->getDevice(DeviceId);
+    assert(isValidDeviceId(DeviceId) && "Invalid device id");
+    assert(Devices[DeviceId] && "Device is uninitialized");
+
+    return *Devices[DeviceId];
   }
 
   /// Get the number of active devices.

Original file line number	Diff line number	Diff line change
`@@ -1295,7 +1295,10 @@ struct GenericPluginTy {`
`1295`	`1295`	`return *Devices[DeviceId];`
`1296`	`1296`	`}`
`1297`	`1297`	`const GenericDeviceTy &getDevice(int32_t DeviceId) const {`
`1298`		`- return const_cast<GenericPluginTy *>(this)->getDevice(DeviceId);`
	`1298`	`+ assert(isValidDeviceId(DeviceId) && "Invalid device id");`
	`1299`	`+ assert(Devices[DeviceId] && "Device is uninitialized");`
	`1300`	`+`
	`1301`	`+ return *Devices[DeviceId];`
`1299`	`1302`	`}`
`1300`	`1303`
`1301`	`1304`	`/// Get the number of active devices.`