Skip to content

Commit c2692af

Browse files
MaskRayMaskRay
committed
[PowerPC] Rename VariantKind to Specifier
Follow the X86 and Mips renaming. > "Relocation modifier" suggests adjustments happen during the linker's relocation step rather than the assembler's expression evaluation. > "Relocation specifier" is clear, aligns with Arm and IBM’s usage, and fits the assembler's role seamlessly. In addition, rename *MCExpr::getKind, which confusingly shadows the base class getKind.
1 parent aa4e6d8 commit c2692af

12 files changed

+117
-120
lines changed

‎llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp

Lines changed: 28 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ class PPCAsmParser : public MCTargetAsmParser {
109109
ParseStatus tryParseRegister(MCRegister &Reg, SMLoc &StartLoc,
110110
SMLoc &EndLoc) override;
111111

112-
const MCExpr *extractModifierFromExpr(const MCExpr *E,
113-
PPCMCExpr::VariantKind &Variant);
112+
const MCExpr *extractSpecifier(const MCExpr *E,
113+
PPCMCExpr::Specifier &Variant);
114114
bool parseExpression(const MCExpr *&EVal);
115115

116116
bool parseOperand(OperandVector &Operands);
@@ -745,8 +745,8 @@ struct PPCOperand : public MCParsedAsmOperand {
745745
return CreateImm(CE->getValue(), S, E, IsPPC64);
746746

747747
if (const MCSymbolRefExpr *SRE = dyn_cast<MCSymbolRefExpr>(Val))
748-
if (getVariantKind(SRE) == PPCMCExpr::VK_TLS ||
749-
getVariantKind(SRE) == PPCMCExpr::VK_TLS_PCREL)
748+
if (getSpecifier(SRE) == PPCMCExpr::VK_TLS ||
749+
getSpecifier(SRE) == PPCMCExpr::VK_TLS_PCREL)
750750
return CreateTLSReg(SRE, S, E, IsPPC64);
751751

752752
if (const PPCMCExpr *TE = dyn_cast<PPCMCExpr>(Val)) {
@@ -1364,15 +1364,14 @@ ParseStatus PPCAsmParser::tryParseRegister(MCRegister &Reg, SMLoc &StartLoc,
13641364
return ParseStatus::Success;
13651365
}
13661366

1367-
/// Extract \code @l/@ha \endcode modifier from expression. Recursively scan
1367+
/// Extract \code @l/@ha \endcode specifier from expression. Recursively scan
13681368
/// the expression and check for VK_LO/HI/HA
1369-
/// symbol variants. If all symbols with modifier use the same
1370-
/// variant, return the corresponding PPCMCExpr::VariantKind,
1369+
/// symbol variants. If all symbols with specifier use the same
1370+
/// specifier, return the corresponding PPCMCExpr::Specifier,
13711371
/// and a modified expression using the default symbol variant.
13721372
/// Otherwise, return NULL.
1373-
const MCExpr *
1374-
PPCAsmParser::extractModifierFromExpr(const MCExpr *E,
1375-
PPCMCExpr::VariantKind &Variant) {
1373+
const MCExpr *PPCAsmParser::extractSpecifier(const MCExpr *E,
1374+
PPCMCExpr::Specifier &Variant) {
13761375
MCContext &Context = getParser().getContext();
13771376
Variant = PPCMCExpr::VK_None;
13781377

@@ -1383,7 +1382,7 @@ PPCAsmParser::extractModifierFromExpr(const MCExpr *E,
13831382

13841383
case MCExpr::SymbolRef: {
13851384
const MCSymbolRefExpr *SRE = cast<MCSymbolRefExpr>(E);
1386-
Variant = (PPCMCExpr::VariantKind)SRE->getKind();
1385+
Variant = (PPCMCExpr::Specifier)SRE->getKind();
13871386
switch (Variant) {
13881387
case PPCMCExpr::VK_LO:
13891388
Variant = PPCMCExpr::VK_LO;
@@ -1421,17 +1420,17 @@ PPCAsmParser::extractModifierFromExpr(const MCExpr *E,
14211420

14221421
case MCExpr::Unary: {
14231422
const MCUnaryExpr *UE = cast<MCUnaryExpr>(E);
1424-
const MCExpr *Sub = extractModifierFromExpr(UE->getSubExpr(), Variant);
1423+
const MCExpr *Sub = extractSpecifier(UE->getSubExpr(), Variant);
14251424
if (!Sub)
14261425
return nullptr;
14271426
return MCUnaryExpr::create(UE->getOpcode(), Sub, Context);
14281427
}
14291428

14301429
case MCExpr::Binary: {
14311430
const MCBinaryExpr *BE = cast<MCBinaryExpr>(E);
1432-
PPCMCExpr::VariantKind LHSVariant, RHSVariant;
1433-
const MCExpr *LHS = extractModifierFromExpr(BE->getLHS(), LHSVariant);
1434-
const MCExpr *RHS = extractModifierFromExpr(BE->getRHS(), RHSVariant);
1431+
PPCMCExpr::Specifier LHSVariant, RHSVariant;
1432+
const MCExpr *LHS = extractSpecifier(BE->getLHS(), LHSVariant);
1433+
const MCExpr *RHS = extractSpecifier(BE->getRHS(), RHSVariant);
14351434

14361435
if (!LHS && !RHS)
14371436
return nullptr;
@@ -1463,10 +1462,10 @@ bool PPCAsmParser::parseExpression(const MCExpr *&EVal) {
14631462
if (getParser().parseExpression(EVal))
14641463
return true;
14651464

1466-
PPCMCExpr::VariantKind Variant;
1467-
const MCExpr *E = extractModifierFromExpr(EVal, Variant);
1465+
PPCMCExpr::Specifier Spec;
1466+
const MCExpr *E = extractSpecifier(EVal, Spec);
14681467
if (E)
1469-
EVal = PPCMCExpr::create(Variant, E, getParser().getContext());
1468+
EVal = PPCMCExpr::create(Spec, E, getParser().getContext());
14701469

14711470
return false;
14721471
}
@@ -1854,21 +1853,21 @@ PPCAsmParser::applyModifierToExpr(const MCExpr *E,
18541853
MCSymbolRefExpr::VariantKind Variant,
18551854
MCContext &Ctx) {
18561855
if (isa<MCConstantExpr>(E)) {
1857-
switch (PPCMCExpr::VariantKind(Variant)) {
1858-
case PPCMCExpr::VariantKind::VK_LO:
1859-
case PPCMCExpr::VariantKind::VK_HI:
1860-
case PPCMCExpr::VariantKind::VK_HA:
1861-
case PPCMCExpr::VariantKind::VK_HIGH:
1862-
case PPCMCExpr::VariantKind::VK_HIGHA:
1863-
case PPCMCExpr::VariantKind::VK_HIGHER:
1864-
case PPCMCExpr::VariantKind::VK_HIGHERA:
1865-
case PPCMCExpr::VariantKind::VK_HIGHEST:
1866-
case PPCMCExpr::VariantKind::VK_HIGHESTA:
1856+
switch (PPCMCExpr::Specifier(Variant)) {
1857+
case PPCMCExpr::VK_LO:
1858+
case PPCMCExpr::VK_HI:
1859+
case PPCMCExpr::VK_HA:
1860+
case PPCMCExpr::VK_HIGH:
1861+
case PPCMCExpr::VK_HIGHA:
1862+
case PPCMCExpr::VK_HIGHER:
1863+
case PPCMCExpr::VK_HIGHERA:
1864+
case PPCMCExpr::VK_HIGHEST:
1865+
case PPCMCExpr::VK_HIGHESTA:
18671866
break;
18681867
default:
18691868
return nullptr;
18701869
}
18711870
}
18721871

1873-
return PPCMCExpr::create(PPCMCExpr::VariantKind(Variant), E, Ctx);
1872+
return PPCMCExpr::create(PPCMCExpr::Specifier(Variant), E, Ctx);
18741873
}

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ PPCELFObjectWriter::PPCELFObjectWriter(bool Is64Bit, uint8_t OSABI)
3838
Is64Bit ? ELF::EM_PPC64 : ELF::EM_PPC,
3939
/*HasRelocationAddend*/ true) {}
4040

41-
static PPCMCExpr::VariantKind getAccessVariant(const MCValue &Target,
42-
const MCFixup &Fixup) {
41+
static PPCMCExpr::Specifier getAccessVariant(const MCValue &Target,
42+
const MCFixup &Fixup) {
4343
const MCExpr *Expr = Fixup.getValue();
4444

4545
if (Expr->getKind() != MCExpr::Target)
46-
return PPCMCExpr::VariantKind(Target.getAccessVariant());
46+
return PPCMCExpr::Specifier(Target.getAccessVariant());
4747
return cast<PPCMCExpr>(Expr)->getKind();
4848
}
4949

@@ -53,10 +53,10 @@ unsigned PPCELFObjectWriter::getRelocType(MCContext &Ctx, const MCValue &Target,
5353
MCFixupKind Kind = Fixup.getKind();
5454
if (Kind >= FirstLiteralRelocationKind)
5555
return Kind - FirstLiteralRelocationKind;
56-
auto RefKind = static_cast<PPCMCExpr::VariantKind>(Target.getRefKind());
56+
auto RefKind = static_cast<PPCMCExpr::Specifier>(Target.getRefKind());
5757
auto Modifier = getAccessVariant(Target, Fixup);
5858

59-
switch (PPCMCExpr::VariantKind(Modifier)) {
59+
switch (PPCMCExpr::Specifier(Modifier)) {
6060
case PPCMCExpr::VK_DTPMOD:
6161
case PPCMCExpr::VK_DTPREL:
6262
case PPCMCExpr::VK_DTPREL_HA:

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFStreamer.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ void PPCELFStreamer::emitGOTToPCRelReloc(const MCInst &Inst) {
139139
// Cast the last operand to MCSymbolRefExpr to get the symbol.
140140
const MCExpr *Expr = Operand.getExpr();
141141
const MCSymbolRefExpr *SymExpr = static_cast<const MCSymbolRefExpr *>(Expr);
142-
assert(getVariantKind(SymExpr) == PPCMCExpr::VK_PCREL_OPT &&
142+
assert(getSpecifier(SymExpr) == PPCMCExpr::VK_PCREL_OPT &&
143143
"Expecting a symbol of type VK_PCREL_OPT");
144144
MCSymbol *LabelSym =
145145
getContext().getOrCreateSymbol(SymExpr->getSymbol().getName());
@@ -174,7 +174,7 @@ void PPCELFStreamer::emitGOTToPCRelLabel(const MCInst &Inst) {
174174
// Cast the last operand to MCSymbolRefExpr to get the symbol.
175175
const MCExpr *Expr = Operand.getExpr();
176176
const MCSymbolRefExpr *SymExpr = static_cast<const MCSymbolRefExpr *>(Expr);
177-
assert(getVariantKind(SymExpr) == PPCMCExpr::VK_PCREL_OPT &&
177+
assert(getSpecifier(SymExpr) == PPCMCExpr::VK_PCREL_OPT &&
178178
"Expecting a symbol of type VK_PCREL_OPT");
179179
MCSymbol *LabelSym =
180180
getContext().getOrCreateSymbol(SymExpr->getSymbol().getName());
@@ -212,7 +212,7 @@ std::optional<bool> llvm::isPartOfGOTToPCRelPair(const MCInst &Inst,
212212
// Check for the variant kind VK_PCREL_OPT in this expression.
213213
const MCExpr *Expr = Operand.getExpr();
214214
const MCSymbolRefExpr *SymExpr = static_cast<const MCSymbolRefExpr *>(Expr);
215-
if (!SymExpr || getVariantKind(SymExpr) != PPCMCExpr::VK_PCREL_OPT)
215+
if (!SymExpr || getSpecifier(SymExpr) != PPCMCExpr::VK_PCREL_OPT)
216216
return std::nullopt;
217217

218218
return (Inst.getOpcode() == PPC::PLDpc);

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ void PPCInstPrinter::printInst(const MCInst *MI, uint64_t Address,
9292
const MCSymbolRefExpr *SymExpr =
9393
static_cast<const MCSymbolRefExpr *>(Expr);
9494

95-
if (SymExpr && getVariantKind(SymExpr) == PPCMCExpr::VK_PCREL_OPT) {
95+
if (SymExpr && getSpecifier(SymExpr) == PPCMCExpr::VK_PCREL_OPT) {
9696
const MCSymbol &Symbol = SymExpr->getSymbol();
9797
if (MI->getOpcode() == PPC::PLDpc) {
9898
printInstruction(MI, Address, STI, O);
@@ -580,13 +580,13 @@ void PPCInstPrinter::printTLSCall(const MCInst *MI, unsigned OpNo,
580580
// because we do not want the assembly to print out the @notoc at the
581581
// end like __tls_get_addr(x@tlsgd)@notoc. Instead we want it to look
582582
// like __tls_get_addr@notoc(x@tlsgd).
583-
if (getVariantKind(RefExp) == PPCMCExpr::VK_NOTOC)
583+
if (getSpecifier(RefExp) == PPCMCExpr::VK_NOTOC)
584584
O << '@' << MAI.getVariantKindName(RefExp->getKind());
585585
O << '(';
586586
printOperand(MI, OpNo + 1, STI, O);
587587
O << ')';
588-
if (getVariantKind(RefExp) != PPCMCExpr::VK_None &&
589-
getVariantKind(RefExp) != PPCMCExpr::VK_NOTOC)
588+
if (getSpecifier(RefExp) != PPCMCExpr::VK_None &&
589+
getSpecifier(RefExp) != PPCMCExpr::VK_NOTOC)
590590
O << '@' << MAI.getVariantKindName(RefExp->getKind());
591591
if (Rhs) {
592592
SmallString<0> Buf;

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -329,11 +329,11 @@ PPCMCCodeEmitter::getDispRI34PCRelEncoding(const MCInst &MI, unsigned OpNo,
329329
const MCSymbolRefExpr *SRE = cast<MCSymbolRefExpr>(Expr);
330330
(void)SRE;
331331
// Currently these are the only valid PCRelative Relocations.
332-
assert((getVariantKind(SRE) == PPCMCExpr::VK_PCREL ||
333-
getVariantKind(SRE) == PPCMCExpr::VK_GOT_PCREL ||
334-
getVariantKind(SRE) == PPCMCExpr::VK_GOT_TLSGD_PCREL ||
335-
getVariantKind(SRE) == PPCMCExpr::VK_GOT_TLSLD_PCREL ||
336-
getVariantKind(SRE) == PPCMCExpr::VK_GOT_TPREL_PCREL) &&
332+
assert((getSpecifier(SRE) == PPCMCExpr::VK_PCREL ||
333+
getSpecifier(SRE) == PPCMCExpr::VK_GOT_PCREL ||
334+
getSpecifier(SRE) == PPCMCExpr::VK_GOT_TLSGD_PCREL ||
335+
getSpecifier(SRE) == PPCMCExpr::VK_GOT_TLSLD_PCREL ||
336+
getSpecifier(SRE) == PPCMCExpr::VK_GOT_TPREL_PCREL) &&
337337
"VariantKind must be VK_PCREL or VK_GOT_PCREL or "
338338
"VK_GOT_TLSGD_PCREL or VK_GOT_TLSLD_PCREL or "
339339
"VK_GOT_TPREL_PCREL.");
@@ -368,8 +368,8 @@ PPCMCCodeEmitter::getDispRI34PCRelEncoding(const MCInst &MI, unsigned OpNo,
368368
"Value must fit in 34 bits.");
369369

370370
// Currently these are the only valid PCRelative Relocations.
371-
assert((getVariantKind(SRE) == PPCMCExpr::VK_PCREL ||
372-
getVariantKind(SRE) == PPCMCExpr::VK_GOT_PCREL) &&
371+
assert((getSpecifier(SRE) == PPCMCExpr::VK_PCREL ||
372+
getSpecifier(SRE) == PPCMCExpr::VK_GOT_PCREL) &&
373373
"VariantKind must be VK_PCREL or VK_GOT_PCREL");
374374
// Generate the fixup for the relocation.
375375
Fixups.push_back(
@@ -433,7 +433,7 @@ unsigned PPCMCCodeEmitter::getTLSRegEncoding(const MCInst &MI, unsigned OpNo,
433433
// if using PC relative memops.
434434
const MCExpr *Expr = MO.getExpr();
435435
const MCSymbolRefExpr *SRE = cast<MCSymbolRefExpr>(Expr);
436-
bool IsPCRel = getVariantKind(SRE) == PPCMCExpr::VK_TLS_PCREL;
436+
bool IsPCRel = getSpecifier(SRE) == PPCMCExpr::VK_TLS_PCREL;
437437
Fixups.push_back(MCFixup::create(IsPCRel ? 1 : 0, Expr,
438438
(MCFixupKind)PPC::fixup_ppc_nofixup));
439439
const Triple &TT = STI.getTargetTriple();

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ using namespace llvm;
2020

2121
#define DEBUG_TYPE "ppcmcexpr"
2222

23-
const PPCMCExpr *PPCMCExpr::create(VariantKind Kind, const MCExpr *Expr,
23+
const PPCMCExpr *PPCMCExpr::create(Specifier S, const MCExpr *Expr,
2424
MCContext &Ctx) {
25-
return new (Ctx) PPCMCExpr(Kind, Expr);
25+
return new (Ctx) PPCMCExpr(S, Expr);
2626
}
2727

2828
void PPCMCExpr::printImpl(raw_ostream &OS, const MCAsmInfo *MAI) const {
2929
getSubExpr()->print(OS, MAI);
30-
OS << '@' << MAI->getVariantKindName(Kind);
30+
OS << '@' << MAI->getVariantKindName(specifier);
3131
}
3232

3333
bool
@@ -47,7 +47,7 @@ PPCMCExpr::evaluateAsConstant(int64_t &Res) const {
4747
}
4848

4949
std::optional<int64_t> PPCMCExpr::evaluateAsInt64(int64_t Value) const {
50-
switch (Kind) {
50+
switch (specifier) {
5151
case VK_LO:
5252
return Value & 0xffff;
5353
case VK_HI:

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.h

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ namespace llvm {
1717

1818
class PPCMCExpr : public MCTargetExpr {
1919
public:
20-
enum VariantKind {
20+
enum Specifier {
2121
VK_None,
2222

2323
// We currently use both MCSymbolRefExpr::VariantKind and
24-
// PPCMCExpr::VariantKind. Start at a larger number to avoid conflicts.
24+
// PPCMCExpr::Specifier. Start at a larger number to avoid conflicts.
2525
VK_LO = 200,
2626
VK_HI,
2727
VK_HA,
@@ -102,19 +102,19 @@ class PPCMCExpr : public MCTargetExpr {
102102
};
103103

104104
private:
105-
const VariantKind Kind;
105+
const Specifier specifier;
106106
const MCExpr *Expr;
107107

108108
std::optional<int64_t> evaluateAsInt64(int64_t Value) const;
109109

110-
explicit PPCMCExpr(VariantKind Kind, const MCExpr *Expr)
111-
: Kind(Kind), Expr(Expr) {}
110+
explicit PPCMCExpr(Specifier S, const MCExpr *Expr)
111+
: specifier(S), Expr(Expr) {}
112112

113113
public:
114114
/// @name Construction
115115
/// @{
116116

117-
static const PPCMCExpr *create(VariantKind Kind, const MCExpr *Expr,
117+
static const PPCMCExpr *create(Specifier S, const MCExpr *Expr,
118118
MCContext &Ctx);
119119

120120
static const PPCMCExpr *createLo(const MCExpr *Expr, MCContext &Ctx) {
@@ -133,8 +133,7 @@ class PPCMCExpr : public MCTargetExpr {
133133
/// @name Accessors
134134
/// @{
135135

136-
/// getOpcode - Get the kind of this expression.
137-
VariantKind getKind() const { return Kind; }
136+
Specifier getKind() const { return specifier; }
138137

139138
/// getSubExpr - Get the child of this expression.
140139
const MCExpr *getSubExpr() const { return Expr; }
@@ -156,9 +155,8 @@ class PPCMCExpr : public MCTargetExpr {
156155
}
157156
};
158157

159-
static inline PPCMCExpr::VariantKind
160-
getVariantKind(const MCSymbolRefExpr *SRE) {
161-
return PPCMCExpr::VariantKind(SRE->getKind());
158+
static inline PPCMCExpr::Specifier getSpecifier(const MCSymbolRefExpr *SRE) {
159+
return PPCMCExpr::Specifier(SRE->getKind());
162160
}
163161

164162
} // end namespace llvm

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class PPCTargetAsmStreamer : public PPCTargetStreamer {
209209
PPCTargetAsmStreamer(MCStreamer &S, formatted_raw_ostream &OS)
210210
: PPCTargetStreamer(S), OS(OS) {}
211211

212-
void emitTCEntry(const MCSymbol &S, PPCMCExpr::VariantKind Kind) override {
212+
void emitTCEntry(const MCSymbol &S, PPCMCExpr::Specifier Kind) override {
213213
if (const MCSymbolXCOFF *XSym = dyn_cast<MCSymbolXCOFF>(&S)) {
214214
MCSymbolXCOFF *TCSym =
215215
cast<MCSectionXCOFF>(Streamer.getCurrentSectionOnly())
@@ -268,7 +268,7 @@ class PPCTargetELFStreamer : public PPCTargetStreamer {
268268
return static_cast<MCELFStreamer &>(Streamer);
269269
}
270270

271-
void emitTCEntry(const MCSymbol &S, PPCMCExpr::VariantKind Kind) override {
271+
void emitTCEntry(const MCSymbol &S, PPCMCExpr::Specifier Kind) override {
272272
// Creates a R_PPC64_TOC relocation
273273
Streamer.emitValueToAlignment(Align(8));
274274
Streamer.emitSymbolValue(&S, 8);
@@ -372,7 +372,7 @@ class PPCTargetMachOStreamer : public PPCTargetStreamer {
372372
public:
373373
PPCTargetMachOStreamer(MCStreamer &S) : PPCTargetStreamer(S) {}
374374

375-
void emitTCEntry(const MCSymbol &S, PPCMCExpr::VariantKind Kind) override {
375+
void emitTCEntry(const MCSymbol &S, PPCMCExpr::Specifier Kind) override {
376376
llvm_unreachable("Unknown pseudo-op: .tc");
377377
}
378378

@@ -394,7 +394,7 @@ class PPCTargetXCOFFStreamer : public PPCTargetStreamer {
394394
public:
395395
PPCTargetXCOFFStreamer(MCStreamer &S) : PPCTargetStreamer(S) {}
396396

397-
void emitTCEntry(const MCSymbol &S, PPCMCExpr::VariantKind Kind) override {
397+
void emitTCEntry(const MCSymbol &S, PPCMCExpr::Specifier Kind) override {
398398
const MCAsmInfo *MAI = Streamer.getContext().getAsmInfo();
399399
const unsigned PointerSize = MAI->getCodePointerSize();
400400
Streamer.emitValueToAlignment(Align(PointerSize));

‎llvm/lib/Target/PowerPC/MCTargetDesc/PPCTargetStreamer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class PPCTargetStreamer : public MCTargetStreamer {
2525
PPCTargetStreamer(MCStreamer &S);
2626
~PPCTargetStreamer() override;
2727

28-
virtual void emitTCEntry(const MCSymbol &S, PPCMCExpr::VariantKind Kind) {}
28+
virtual void emitTCEntry(const MCSymbol &S, PPCMCExpr::Specifier Kind) {}
2929
virtual void emitMachine(StringRef CPU){};
3030
virtual void emitAbiVersion(int AbiVersion){};
3131
virtual void emitLocalEntry(MCSymbolELF *S, const MCExpr *LocalOffset){};

0 commit comments

Comments
 (0)