[Clang][NFC] Move UntypedParameters instead of copy (#143646)

shafik · web-flow · commit c2cb571c6cbc · 2025-06-10T23:41:41.000-07:00
Static analysis flagged that UntypedParameters could be moved instead of
copied. This would avoid copying a large object.
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
@@ -2888,7 +2888,7 @@ static bool resolveAllocationOverload(
     // type-identity-less argument list.
     IAP.PassTypeIdentity = TypeAwareAllocationMode::No;
     IAP.PassAlignment = InitialAlignmentMode;
-    Args = UntypedParameters;
+    Args = std::move(UntypedParameters);
   }
   assert(!S.isStdTypeIdentity(Args[0]->getType(), nullptr));
   return resolveAllocationOverloadInterior(

Original file line number	Diff line number	Diff line change
`@@ -2888,7 +2888,7 @@ static bool resolveAllocationOverload(`
`2888`	`2888`	`// type-identity-less argument list.`
`2889`	`2889`	`IAP.PassTypeIdentity = TypeAwareAllocationMode::No;`
`2890`	`2890`	`IAP.PassAlignment = InitialAlignmentMode;`
`2891`		`- Args = UntypedParameters;`
	`2891`	`+ Args = std::move(UntypedParameters);`
`2892`	`2892`	`}`
`2893`	`2893`	`assert(!S.isStdTypeIdentity(Args[0]->getType(), nullptr));`
`2894`	`2894`	`return resolveAllocationOverloadInterior(`