address comments

matthias-springer · matthias-springer · commit c2f1f22b44ca · 2025-03-16T21:41:17.000+01:00
diff --git a/mlir/lib/Tools/PDLL/CodeGen/MLIRGen.cpp b/mlir/lib/Tools/PDLL/CodeGen/MLIRGen.cpp
@@ -387,8 +387,7 @@ Value CodeGen::genSingleExpr(const ast::Expr *expr) {
           [&](auto derivedNode) { return this->genExprImpl(derivedNode); })
       .Case<const ast::CallExpr, const ast::DeclRefExpr, const ast::TupleExpr>(
           [&](auto derivedNode) {
-            SmallVector<Value> results = this->genExprImpl(derivedNode);
-            return llvm::getSingleElement(results);
+            return llvm::getSingleElement(this->genExprImpl(derivedNode));
           });
 }
 

Original file line number	Diff line number	Diff line change
`@@ -387,8 +387,7 @@ Value CodeGen::genSingleExpr(const ast::Expr *expr) {`
`387`	`387`	`[&](auto derivedNode) { return this->genExprImpl(derivedNode); })`
`388`	`388`	`.Case<const ast::CallExpr, const ast::DeclRefExpr, const ast::TupleExpr>(`
`389`	`389`	`[&](auto derivedNode) {`
`390`		`- SmallVector<Value> results = this->genExprImpl(derivedNode);`
`391`		`- return llvm::getSingleElement(results);`
	`390`	`+ return llvm::getSingleElement(this->genExprImpl(derivedNode));`
`392`	`391`	`});`
`393`	`392`	`}`
`394`	`393`