[InstCombine] Address review comments.

Author: dtcxzyw

llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

@@ -3529,6 +3529,7 @@ Value *InstCombinerImpl::foldAndOrOfICmps(ICmpInst *LHS, ICmpInst *RHS,
   if (LHS0 == RHS0 && PredL == PredR &&
       PredL == (IsAnd ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ) &&
       !I.getFunction()->hasFnAttribute(Attribute::NoImplicitFloat) &&
+      LHS->hasOneUse() && RHS->hasOneUse() &&
       match(LHS0, m_And(m_ElementWiseBitCast(m_Value(X)), m_APInt(MaskC))) &&
       X->getType()->getScalarType()->isIEEELikeFPTy() &&
       APFloat(X->getType()->getScalarType()->getFltSemantics(), *MaskC)

llvm/test/Transforms/InstCombine/fpclass-check-idioms.ll

@@ -1069,6 +1069,20 @@ define i1 @fpclass_test_not_normal(float %num) {
   ret i1 %res
 }
 
+define <2 x i1> @fpclass_test_not_normal_vec(<2 x float> %num) {
+; CHECK-LABEL: define <2 x i1> @fpclass_test_not_normal_vec(
+; CHECK-SAME: <2 x float> [[NUM:%.*]]) {
+; CHECK-NEXT:    [[RES:%.*]] = call <2 x i1> @llvm.is.fpclass.v2f32(<2 x float> [[NUM]], i32 759)
+; CHECK-NEXT:    ret <2 x i1> [[RES]]
+;
+  %cast = bitcast <2 x float> %num to <2 x i32>
+  %masked = and <2 x i32> %cast, splat(i32 2139095040)
+  %test1 = icmp eq <2 x i32> %masked, splat(i32 2139095040)
+  %test2 = icmp eq <2 x i32> %masked, zeroinitializer
+  %res = or <2 x i1> %test1, %test2
+  ret <2 x i1> %res
+}
+
 define i1 @fpclass_test_normal_commuted(float %num) {
 ; CHECK-LABEL: define i1 @fpclass_test_normal_commuted(
 ; CHECK-SAME: float [[NUM:%.*]]) {
@@ -1083,6 +1097,26 @@ define i1 @fpclass_test_normal_commuted(float %num) {
   ret i1 %res
 }
 
+; Negative tests
+
+define i1 @fpclass_test_normal_fp128(ppc_fp128 %x) {
+; CHECK-LABEL: define i1 @fpclass_test_normal_fp128(
+; CHECK-SAME: ppc_fp128 [[X:%.*]]) {
+; CHECK-NEXT:    [[BITS:%.*]] = bitcast ppc_fp128 [[X]] to i128
+; CHECK-NEXT:    [[MASKED:%.*]] = and i128 [[BITS]], 170058106710732674489630815774616584192
+; CHECK-NEXT:    [[TEST1:%.*]] = icmp ne i128 [[MASKED]], 170058106710732674489630815774616584192
+; CHECK-NEXT:    [[TEST2:%.*]] = icmp ne i128 [[MASKED]], 0
+; CHECK-NEXT:    [[RES:%.*]] = and i1 [[TEST2]], [[TEST1]]
+; CHECK-NEXT:    ret i1 [[RES]]
+;
+  %bits = bitcast ppc_fp128 %x to i128
+  %masked = and i128 %bits, 170058106710732674489630815774616584192
+  %test1 = icmp ne i128 %masked, 170058106710732674489630815774616584192
+  %test2 = icmp ne i128 %masked, 0
+  %res = and i1 %test2, %test1
+  ret i1 %res
+}
+
 define i1 @fpclass_test_normal_mismatch_pred(float %num) {
 ; CHECK-LABEL: define i1 @fpclass_test_normal_mismatch_pred(
 ; CHECK-SAME: float [[NUM:%.*]]) {
@@ -1169,6 +1203,27 @@ define i1 @fpclass_test_normal_invalid_constant3(float %num) {
   ret i1 %res
 }
 
+define i1 @fpclass_test_normal_multiuse(float %num) {
+; CHECK-LABEL: define i1 @fpclass_test_normal_multiuse(
+; CHECK-SAME: float [[NUM:%.*]]) {
+; CHECK-NEXT:    [[CAST:%.*]] = bitcast float [[NUM]] to i32
+; CHECK-NEXT:    [[MASKED:%.*]] = and i32 [[CAST]], 2139095040
+; CHECK-NEXT:    [[TEST1:%.*]] = icmp ne i32 [[MASKED]], 2139095040
+; CHECK-NEXT:    [[TEST2:%.*]] = icmp ne i32 [[MASKED]], 0
+; CHECK-NEXT:    call void @usei1(i1 [[TEST1]])
+; CHECK-NEXT:    [[RES:%.*]] = and i1 [[TEST1]], [[TEST2]]
+; CHECK-NEXT:    ret i1 [[RES]]
+;
+  %cast = bitcast float %num to i32
+  %masked = and i32 %cast, 2139095040
+  %test1 = icmp ne i32 %masked, 2139095040
+  %test2 = icmp ne i32 %masked, 0
+  call void @usei1(i1 %test1)
+  %res = and i1 %test1, %test2
+  ret i1 %res
+}
+
 declare void @usei32(i32)
+declare void @usei1(i1)
 
 attributes #0 = { noimplicitfloat }