Skip to content

Commit c36881d

Browse files
committed
Review feedback (improved comments, mandatory REQUIRES)
1 parent ba944d4 commit c36881d

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

llvm/lib/MC/MCObjectStreamer.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,9 @@ void MCObjectStreamer::emitDwarfAdvanceLineAddr(int64_t LineDelta,
465465
return;
466466
}
467467

468-
// If the two labels are within the same fragment and it's a plain data
469-
// fragment, then the address-offset is already a fixed constant and is not
470-
// relaxable. Emit the advance-line-addr data immediately to save time and
471-
// memory.
468+
// If the two labels are within the same fragment, then the address-offset is
469+
// already a fixed constant and is not relaxable. Emit the advance-line-addr
470+
// data immediately to save time and memory.
472471
if (auto OptAddrDelta = absoluteSymbolDiff(Label, LastLabel)) {
473472
SmallString<16> Tmp;
474473
MCDwarfLineAddr::encode(getContext(), Assembler->getDWARFLinetableParams(),

llvm/test/DebugInfo/X86/debug-line-in-one-fragment.ll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
; RUN: llc %s -o %t.o -filetype=obj
22
; RUN: llvm-dwarfdump --debug-line %t.o | FileCheck %s --check-prefix=LINES
33
; RUN: llc %s -o %t.o -filetype=obj -debug-only=mc-dump 2>&1 | FileCheck %s --check-prefix=FRAGMENTS
4+
;
5+
; REQUIRES: asserts
46

57
;; Test (using mc-dump debug output) that .debug_line can be arranged in memory
68
;; using a single data fragment for a simple function, instead of using multiple

0 commit comments

Comments
 (0)