nit

Author: wldfngrs

libc/src/math/generic/CMakeLists.txt

@@ -356,7 +356,6 @@ add_header_library(
   HDRS
     sincosf16_utils.h
   DEPENDS
-    .range_reduction
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.FPUtil.polyeval
     libc.src.__support.FPUtil.nearest_integer

libc/src/math/generic/cospif16.cpp

@@ -7,13 +7,17 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/math/cospif16.h"
+#include "hdr/errno_macros.h"
+#include "hdr/fenv_macros.h"
 #include "sincosf16_utils.h"
 #include "src/__support/FPUtil/FEnvImpl.h"
 #include "src/__support/FPUtil/FPBits.h"
 #include "src/__support/FPUtil/cast.h"
 #include "src/__support/FPUtil/multiply_add.h"
+#include "src/__support/macros/optimization.h"
 
 namespace LIBC_NAMESPACE_DECL {
+
 LLVM_LIBC_FUNCTION(float16, cospif16, (float16 x)) {
   using FPBits = typename fputil::FPBits<float16>;
   FPBits xbits(x);
@@ -49,9 +53,8 @@ LLVM_LIBC_FUNCTION(float16, cospif16, (float16 x)) {
 
   // Numbers greater or equal to 2^10 are integers, or infinity, or NaN
   if (LIBC_UNLIKELY(x_abs >= 0x6400)) {
-    if (LIBC_UNLIKELY(x_abs <= 0x67FF)) {
+    if (LIBC_UNLIKELY(x_abs <= 0x67FF))
       return fputil::cast<float16>((x_abs & 0x1) ? -1.0f : 1.0f);
-    }
 
     // Check for NaN or infintiy values
     if (LIBC_UNLIKELY(x_abs >= 0x7c00)) {

libc/src/math/generic/sincosf16_utils.h

@@ -5,6 +5,7 @@
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
+
 #ifndef LLVM_LIBC_SRC_MATH_GENERIC_SINCOSF16_UTILS_H
 #define LLVM_LIBC_SRC_MATH_GENERIC_SINCOSF16_UTILS_H
 
@@ -38,7 +39,7 @@ constexpr float SIN_K_PI_OVER_32[64] = {
     -0x1.6a09e6p-1, -0x1.44cf32p-1, -0x1.1c73b4p-1, -0x1.e2b5d4p-2,
     -0x1.87de2ap-2, -0x1.294062p-2, -0x1.8f8b84p-3, -0x1.917a6cp-4};
 
-LIBC_INLINE int32_t range_reduction(float x, float &y) {
+LIBC_INLINE int32_t range_reduction_sincospif16(float x, float &y) {
   float kf = fputil::nearest_integer(x * 32);
   y = fputil::multiply_add<float>(x, 32.0, -kf);
 
@@ -48,7 +49,7 @@ LIBC_INLINE int32_t range_reduction(float x, float &y) {
 LIBC_INLINE void sincospif16_eval(float xf, float &sin_k, float &cos_k,
                                   float &sin_y, float &cosm1_y) {
   float y;
-  int32_t k = range_reduction(xf, y);
+  int32_t k = range_reduction_sincospif16(xf, y);
 
   sin_k = SIN_K_PI_OVER_32[k & 63];
   cos_k = SIN_K_PI_OVER_32[(k + 16) & 63];