major fixes

Author: vbvictor

clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp

@@ -44,17 +44,15 @@ AST_MATCHER(CXXRecordDecl, correctHandleCaptureThisLambda) {
   if (Node.hasSimpleMoveAssignment())
     return false;
 
-  for (const CXXConstructorDecl *C : Node.ctors()) {
-    if (C->isCopyOrMoveConstructor() && C->isDefaulted() && !C->isDeleted())
-      return false;
-  }
+  if (llvm::any_of(Node.ctors(), [](const CXXConstructorDecl *C) {
+        return C->isCopyOrMoveConstructor() && C->isDefaulted() &&
+               !C->isDeleted();
+      }))
+    return false;
   if (llvm::any_of(Node.methods(), [](const CXXMethodDecl *M) {
-        if (M->isCopyAssignmentOperator())
-          llvm::errs() << M->isDeleted() << "\n";
-        return (M->isCopyAssignmentOperator() && M->isDefaulted() &&
-                !M->isDeleted()) ||
-               (M->isMoveAssignmentOperator() && M->isDefaulted() &&
-                !M->isDeleted());
+        return (M->isCopyAssignmentOperator() ||
+                M->isMoveAssignmentOperator()) &&
+               M->isDefaulted() && !M->isDeleted();
       }))
     return false;
   // FIXME: find ways to identifier correct handle capture this lambda

clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp

@@ -1589,7 +1589,7 @@ static bool lazyMapOfSetsIntersectionExists(const MapTy &Map, const ElemTy &E1,
   if (E1Iterator == Map.end() || E2Iterator == Map.end())
     return false;
 
-  return llvm::any_of(E1Iterator->second, [&](const auto &E1SetElem) {
+  return llvm::any_of(E1Iterator->second, [&E2Iterator](const auto &E1SetElem) {
     return E2Iterator->second.contains(E1SetElem);
   });
 }

clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp

@@ -19,10 +19,11 @@ namespace clang::tidy::cppcoreguidelines {
 namespace {
 AST_MATCHER_P(CXXForRangeStmt, hasRangeBeginEndStmt,
               ast_matchers::internal::Matcher<DeclStmt>, InnerMatcher) {
-  const DeclStmt *Stmts[] = {Node.getBeginStmt(), Node.getEndStmt()};
-  return llvm::any_of(Stmts, [&](const DeclStmt *Stmt) {
-    return Stmt != nullptr && InnerMatcher.matches(*Stmt, Finder, Builder);
-  });
+  return llvm::any_of(llvm::ArrayRef{Node.getBeginStmt(), Node.getEndStmt()},
+                      [&](const DeclStmt *Stmt) {
+                        return Stmt &&
+                               InnerMatcher.matches(*Stmt, Finder, Builder);
+                      });
 }
 
 AST_MATCHER(Stmt, isInsideOfRangeBeginEndStmt) {

clang-tools-extra/clang-tidy/misc/NewDeleteOverloadsCheck.cpp

@@ -114,12 +114,12 @@ hasCorrespondingOverloadInBaseClass(const CXXMethodDecl *MD,
     RD = MD->getParent();
   }
 
-  return llvm::any_of(RD->bases(), [&](const auto &BS) {
+  return llvm::any_of(RD->bases(), [&](const CXXBaseSpecifier &BS) {
     // We can't say much about a dependent base class, but to avoid false
     // positives assume it can have a corresponding overload.
     if (BS.getType()->isDependentType())
       return true;
-    if (const auto *BaseRD = BS.getType()->getAsCXXRecordDecl())
+    if (const CXXRecordDecl *BaseRD = BS.getType()->getAsCXXRecordDecl())
       return hasCorrespondingOverloadInBaseClass(MD, BaseRD);
     return false;
   });

clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp

@@ -30,7 +30,7 @@ static bool isOverrideMethod(const FunctionDecl *Function) {
 
 static bool hasAttrAfterParam(const SourceManager *SourceManager,
                               const ParmVarDecl *Param) {
-  return llvm::any_of(Param->attrs(), [&](const auto *Attr) {
+  return llvm::any_of(Param->attrs(), [&](const Attr *Attr) {
     return SourceManager->isBeforeInTranslationUnit(Param->getLocation(),
                                                     Attr->getLocation());
   });

clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

@@ -511,22 +511,22 @@ static bool canBeModified(ASTContext *Context, const Expr *E) {
 /// Returns true when it can be guaranteed that the elements of the
 /// container are not being modified.
 static bool usagesAreConst(ASTContext *Context, const UsageResult &Usages) {
-  return llvm::all_of(Usages, [&](const Usage &U) {
+  return llvm::none_of(Usages, [&Context](const Usage &U) {
     // Lambda captures are just redeclarations (VarDecl) of the same variable,
     // not expressions. If we want to know if a variable that is captured by
     // reference can be modified in an usage inside the lambda's body, we need
     // to find the expression corresponding to that particular usage, later in
     // this loop.
-    return U.Kind == Usage::UK_CaptureByCopy ||
-           U.Kind == Usage::UK_CaptureByRef ||
-           !canBeModified(Context, U.Expression);
+    return U.Kind != Usage::UK_CaptureByCopy &&
+           U.Kind != Usage::UK_CaptureByRef &&
+           canBeModified(Context, U.Expression);
   });
 }
 
 /// Returns true if the elements of the container are never accessed
 /// by reference.
 static bool usagesReturnRValues(const UsageResult &Usages) {
-  return llvm::all_of(Usages, [](const auto &U) {
+  return llvm::all_of(Usages, [](const Usage &U) {
     return !U.Expression || U.Expression->isPRValue();
   });
 }

clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp

@@ -89,7 +89,8 @@ bool DependencyFinderASTVisitor::VisitVarDecl(VarDecl *V) {
 
   // Next, check if the variable was removed from existence by an earlier
   // iteration.
-  if (llvm::all_of(*ReplacedVars, [&](const auto &I) { return I.second != V; }))
+  if (llvm::none_of(*ReplacedVars,
+                    [&](const auto &I) { return I.second == V; }))
     return true;
   DependsOnInsideVariable = true;
   return false;

clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

@@ -45,9 +45,8 @@ AST_MATCHER_P(NamedDecl, hasAnyNameIgnoringTemplates, std::vector<StringRef>,
   // FullNameTrimmed matches any of the given Names.
   const StringRef FullNameTrimmedRef = FullNameTrimmed;
   return llvm::any_of(Names, [&](const StringRef Pattern) {
-    if (Pattern.starts_with("::")) {
+    if (Pattern.starts_with("::"))
       return FullNameTrimmed == Pattern;
-    }
     return FullNameTrimmedRef.ends_with(Pattern) &&
            FullNameTrimmedRef.drop_back(Pattern.size()).ends_with("::");
   });

clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp

@@ -25,7 +25,7 @@ AST_MATCHER_P(ObjCImplementationDecl, hasInterface,
 AST_MATCHER_P(ObjCContainerDecl, hasInstanceMethod,
               ast_matchers::internal::Matcher<ObjCMethodDecl>, Base) {
   // Check each instance method against the provided matcher.
-  return llvm::any_of(Node.instance_methods(), [&](const auto *I) {
+  return llvm::any_of(Node.instance_methods(), [&](const ObjCMethodDecl *I) {
     return Base.matches(*I, Finder, Builder);
   });
 }

clang-tools-extra/clang-tidy/readability/AmbiguousSmartptrResetCallCheck.cpp

@@ -20,8 +20,9 @@ namespace clang::tidy::readability {
 namespace {
 
 AST_MATCHER(CXXMethodDecl, hasOnlyDefaultParameters) {
-  return llvm::all_of(Node.parameters(),
-                      [](const auto *Param) { return Param->hasDefaultArg(); });
+  return llvm::all_of(Node.parameters(), [](const ParmVarDecl *Param) {
+    return Param->hasDefaultArg();
+  });
 }
 
 const auto DefaultSmartPointers = "::std::shared_ptr;::std::unique_ptr;"