Skip to content

Commit c497b8d

Browse files
committed
Fixing the parameter validation of request_source.
1 parent fba6a54 commit c497b8d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,16 +1335,16 @@ def request_source(
13351335
self, *, source: Optional[Source] = None, sourceReference: Optional[int] = None
13361336
):
13371337
"""Request a source from a 'Source' reference."""
1338-
if (
1339-
source is None
1340-
and sourceReference is None
1341-
or (source is not None and sourceReference is not None)
1342-
):
1338+
if source is None and sourceReference is None:
13431339
raise ValueError("request_source requires either source or sourceReference")
1344-
elif source:
1340+
elif source is not None:
13451341
sourceReference = source["sourceReference"]
1346-
elif sourceReference:
1342+
elif sourceReference is not None:
13471343
source = {"sourceReference": sourceReference}
1344+
else:
1345+
raise ValueError(
1346+
"request_source requires either source or sourceReference not both"
1347+
)
13481348
command_dict = {
13491349
"command": "source",
13501350
"type": "request",

0 commit comments

Comments
 (0)