Removed the potential antipattern in clang-tidy.

zahiraam · zahiraam · commit c51acefaa728 · 2025-04-03T12:32:22.000-07:00
diff --git a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext &Context,
     llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
     LowerValue.setBit(PrecisionBits);
     LowerValue.setSignBit();
-    return {std::move(LowerValue), UpperValue};
+    return {LowerValue, UpperValue};
   }
   assert(T.isInteger() && "Unexpected builtin type");
   uint64_t TypeSize = Context.getTypeSize(&T);

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext &Context,`
`260`	`260`	`llvm::APSInt LowerValue(PrecisionBits + 2, /isUnsigned/ false);`
`261`	`261`	`LowerValue.setBit(PrecisionBits);`
`262`	`262`	`LowerValue.setSignBit();`
`263`		`- return {std::move(LowerValue), UpperValue};`
	`263`	`+ return {LowerValue, UpperValue};`
`264`	`264`	`}`
`265`	`265`	`assert(T.isInteger() && "Unexpected builtin type");`
`266`	`266`	`uint64_t TypeSize = Context.getTypeSize(&T);`