Skip to content

Commit c52546a

Browse files
committed
Address feedback on nightly testing and add copy-pasted message
1 parent 8f861a0 commit c52546a

File tree

1 file changed

+29
-15
lines changed

1 file changed

+29
-15
lines changed

llvm/docs/DeveloperPolicy.rst

Lines changed: 29 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,16 @@ work over time. Maintainers are empowered to push back against *extractive*
324324
contributions and explain why they believe a contribution is overly burdensome
325325
or not aligned with the project goals.
326326

327+
If a maintainer judges that a contribution is extractive (i.e. it is generated
328+
with tool-assistance and is not valuable), they should copy-paste the following
329+
response, add the ``extractive`` label if applicable, and refrain from further
330+
engagement::
331+
332+
This PR appears to be extractive, and requires additional justification for
333+
why it is valuable enough to the project for us to review it. Please see
334+
our developer policy on quality and AI contributions:
335+
http://llvm.org/docs/DeveloperPolicy.html#quality
336+
327337
Contribution size is an imperfect proxy of the burden of review, and the
328338
potential user base of the feature is another possible proxy for the value of
329339
the contribution. The best ways to make a change less extractive and more
@@ -441,36 +451,40 @@ reminding the contributor of this policy over reverting.
441451
Post-commit responsibilities
442452
----------------------------
443453

444-
After landing a change, the committer is responsible for addressing any problems
445-
found in the future that the change is responsible for. For example:
454+
There are many important qualities that LLVM aims for, but which we cannot
455+
afford to test for as part of our premerge pipeline. After landing a change,
456+
the committer is responsible for addressing any problems found in the future
457+
that the change is responsible for. Here are some of the issues that arise
458+
post-commit:
446459

447-
* The code should compile cleanly on all supported platforms.
460+
* The code needs to compile cleanly and pass tests on all stable `LLVM
461+
buildbots <https://lab.llvm.org/buildbot/>`_.
448462

449463
* The changes should not cause any correctness regressions in the
450464
`llvm-test-suite <https://github.com/llvm/llvm-test-suite>`_
451465
and must not cause any major performance regressions.
452466

453467
* The change set should not cause performance or correctness regressions for the
454-
LLVM tools.
468+
LLVM tools. See `llvm-compile-time-tracker.com <https://llvm-compile-time-tracker.com>`_
455469

456470
* The changes should not cause performance or correctness regressions in code
457471
compiled by LLVM on all applicable targets.
458472

459473
* You are expected to address any `GitHub Issues
460474
<https://github.com/llvm/llvm-project/issues>`_ that result from your change.
461475

462-
We prefer for this to be handled before submission but understand that it isn't
463-
possible to test all of this for every submission. Our build bots and nightly
464-
testing infrastructure normally finds these problems. A good rule of thumb is
465-
to check the nightly testers for regressions the day after your change. Build
466-
bots will directly email you if a group of commits that included yours caused a
476+
Our build bots and `nightly testing infrastructure
477+
<https://llvm.org/docs/lnt/intro.html>`_ find many of these issues. Build bots
478+
will directly email you if a group of commits that included yours caused a
467479
failure. You are expected to check the build bot messages to see if they are
468-
your fault and, if so, fix the breakage.
469-
470-
Commits that violate these quality standards (e.g. are very broken) may be
471-
reverted. This is necessary when the change blocks other developers from making
472-
progress. The developer is welcome to re-commit the change after the problem has
473-
been fixed.
480+
your fault and, if so, fix the breakage. However, keep in mind that if you
481+
receive such an email, it is highly likely that your change is not at fault.
482+
Changes are batched together precisely because these tests are generally too
483+
expensive to run continuously for every change.
484+
485+
Commits that violate these quality standards may be reverted (see below). This
486+
is necessary when the change blocks other developers from making progress. The
487+
developer is welcome to re-commit the change after the problem has been fixed.
474488

475489
.. _revert_policy:
476490

0 commit comments

Comments
 (0)