make filter

Author: grypp

mlir/lib/Tools/mlir-opt/MlirOptMain.cpp

@@ -226,7 +226,7 @@ struct MlirOptMainConfigCLOptions : public MlirOptMainConfig {
         llvm::cl::cat(remarkCategory)};
 
     static cl::opt<std::string, /*ExternalStorage=*/true> remarksAll(
-        "remarks",
+        "remarks-filter",
         cl::desc("Show all remarks: passed, missed, failed, analysis"),
         cl::location(remarksAllFilterFlag), cl::init(""),
         cl::cat(remarkCategory));
@@ -240,22 +240,22 @@ struct MlirOptMainConfigCLOptions : public MlirOptMainConfig {
         cl::cat(remarkCategory));
 
     static cl::opt<std::string, /*ExternalStorage=*/true> remarksPassed(
-        "remarks-passed", cl::desc("Show passed remarks"),
+        "remarks-passed-filter", cl::desc("Show passed remarks"),
         cl::location(remarksPassedFilterFlag), cl::init(""),
         cl::cat(remarkCategory));
 
     static cl::opt<std::string, /*ExternalStorage=*/true> remarksFailed(
-        "remarks-failed", cl::desc("Show failed remarks"),
+        "remarks-failed-filter", cl::desc("Show failed remarks"),
         cl::location(remarksFailedFilterFlag), cl::init(""),
         cl::cat(remarkCategory));
 
     static cl::opt<std::string, /*ExternalStorage=*/true> remarksMissed(
-        "remarks-missed", cl::desc("Show missed remarks"),
+        "remarks-missed-filter", cl::desc("Show missed remarks"),
         cl::location(remarksMissedFilterFlag), cl::init(""),
         cl::cat(remarkCategory));
 
     static cl::opt<std::string, /*ExternalStorage=*/true> remarksAnalyse(
-        "remarks-analyse", cl::desc("Show analysis remarks"),
+        "remarks-analyse-filter", cl::desc("Show analysis remarks"),
         cl::location(remarksAnalyseFilterFlag), cl::init(""),
         cl::cat(remarkCategory));
 

mlir/test/Pass/remarks.mlir

@@ -1,9 +1,9 @@
-// RUN: mlir-opt %s --test-remark --remarks-passed="category-1-passed" 2>&1 | FileCheck %s -check-prefix=CHECK-PASSED 
-// RUN: mlir-opt %s --test-remark --remarks-missed="a-category-1-missed" 2>&1 | FileCheck %s -check-prefix=CHECK-MISSED
-// RUN: mlir-opt %s --test-remark --remarks-failed="category-2-failed" 2>&1 | FileCheck %s -check-prefix=CHECK-FAILED
-// RUN: mlir-opt %s --test-remark --remarks-analyse="category-2-analysis" 2>&1 | FileCheck %s -check-prefix=CHECK-ANALYSIS
-// RUN: mlir-opt %s --test-remark --remarks="category.*" 2>&1 | FileCheck %s -check-prefix=CHECK-ALL
-// RUN: mlir-opt %s --test-remark --remarks="category-1.*" 2>&1 | FileCheck %s -check-prefix=CHECK-ALL1
+// RUN: mlir-opt %s --test-remark --remarks-passed-filter="category-1-passed" 2>&1 | FileCheck %s -check-prefix=CHECK-PASSED 
+// RUN: mlir-opt %s --test-remark --remarks-missed-filter="a-category-1-missed" 2>&1 | FileCheck %s -check-prefix=CHECK-MISSED
+// RUN: mlir-opt %s --test-remark --remarks-failed-filter="category-2-failed" 2>&1 | FileCheck %s -check-prefix=CHECK-FAILED
+// RUN: mlir-opt %s --test-remark --remarks-analyse-filter="category-2-analysis" 2>&1 | FileCheck %s -check-prefix=CHECK-ANALYSIS
+// RUN: mlir-opt %s --test-remark --remarks-filter="category.*" 2>&1 | FileCheck %s -check-prefix=CHECK-ALL
+// RUN: mlir-opt %s --test-remark --remarks-filter="category-1.*" 2>&1 | FileCheck %s -check-prefix=CHECK-ALL1
 module @foo {
   "test.op"() : () -> ()