Skip to content

Commit c5a0cf5

Browse files
committed
Fix unittest to be more verbose.
1 parent 064868a commit c5a0cf5

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

llvm/unittests/Option/OptionSubCommandsTest.cpp

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,10 @@ TYPED_TEST(OptSubCommandTableTest, SubCommandParsing) {
111111
EXPECT_EQ(SC, "foo");
112112
EXPECT_TRUE(AL.hasArg(OPT_uppercase));
113113
EXPECT_FALSE(AL.hasArg(OPT_lowercase));
114-
EXPECT_FALSE(AL.hasArg(OPT_version));
115-
// Do not expect any error messages as this is a valid use case.
116-
EXPECT_EQ(std::string::npos, ErrMsg.find("Multiple subcommands passed"));
114+
EXPECT_FALSE(AL.hasArg(OPT_version));
115+
EXPECT_EQ(std::string::npos, ErrMsg.find("Multiple subcommands passed")) << "Did not expect error message as this is a valid use case.";
117116
EXPECT_EQ(std::string::npos,
118-
ErrMsg.find("Unregistered positionals passed"));
117+
ErrMsg.find("Unregistered positionals passed")) << "Did not expect error message as this is a valid use case.";
119118
}
120119

121120
{
@@ -128,11 +127,10 @@ TYPED_TEST(OptSubCommandTableTest, SubCommandParsing) {
128127
EXPECT_EQ(SC, "foo");
129128
EXPECT_TRUE(AL.hasArg(OPT_uppercase));
130129
EXPECT_FALSE(AL.hasArg(OPT_lowercase));
131-
EXPECT_FALSE(AL.hasArg(OPT_version));
132-
// Do not expect any error messages as this is a valid use case.
133-
EXPECT_EQ(std::string::npos, ErrMsg.find("Multiple subcommands passed"));
130+
EXPECT_FALSE(AL.hasArg(OPT_version));
131+
EXPECT_EQ(std::string::npos, ErrMsg.find("Multiple subcommands passed")) << "Did not expect error message as this is a valid use case.";
134132
EXPECT_EQ(std::string::npos,
135-
ErrMsg.find("Unregistered positionals passed"));
133+
ErrMsg.find("Unregistered positionals passed")) << "Did not expect error message as this is a valid use case.";
136134
}
137135

138136
{
@@ -147,9 +145,8 @@ TYPED_TEST(OptSubCommandTableTest, SubCommandParsing) {
147145
EXPECT_NE(std::string::npos, ErrMsg.find("Multiple subcommands passed"));
148146
EXPECT_NE(std::string::npos, ErrMsg.find("foo"));
149147
EXPECT_NE(std::string::npos, ErrMsg.find("bar"));
150-
// Do not expect the rnregistered subcommands error message.
151148
EXPECT_EQ(std::string::npos,
152-
ErrMsg.find("Unregistered positionals passed"));
149+
ErrMsg.find("Unregistered positionals passed")) << "Did not expect error message as this is a valid use case.";
153150
}
154151

155152
{
@@ -160,7 +157,7 @@ TYPED_TEST(OptSubCommandTableTest, SubCommandParsing) {
160157
T.getSubCommands(), HandleMultipleSubcommands, HandleOtherPositionals);
161158
// No valid subcommand should be returned as this is an invalid invocation.
162159
EXPECT_TRUE(SC.empty());
163-
// Expect the rnregistered subcommands error message.
160+
// Expect the unregistered subcommands error message.
164161
EXPECT_NE(std::string::npos,
165162
ErrMsg.find("Unregistered positionals passed"));
166163
EXPECT_NE(std::string::npos, ErrMsg.find("foobar"));

0 commit comments

Comments
 (0)