Skip to content

Commit c5c7ab8

Browse files
committed
remove condition - Space is never empty
1 parent 6fb658a commit c5c7ab8

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

clang/lib/Sema/SemaHLSL.cpp

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1588,16 +1588,14 @@ void SemaHLSL::handleResourceBindingAttr(Decl *TheDecl, const ParsedAttr &AL) {
15881588
}
15891589

15901590
// Validate space
1591-
if (!Space.empty()) {
1592-
if (!Space.starts_with("space")) {
1593-
Diag(SpaceLoc, diag::err_hlsl_expected_space) << Space;
1594-
return;
1595-
}
1596-
StringRef SpaceNumStr = Space.substr(5);
1597-
if (SpaceNumStr.getAsInteger(10, SpaceNum)) {
1598-
Diag(SpaceLoc, diag::err_hlsl_expected_space) << Space;
1599-
return;
1600-
}
1591+
if (!Space.starts_with("space")) {
1592+
Diag(SpaceLoc, diag::err_hlsl_expected_space) << Space;
1593+
return;
1594+
}
1595+
StringRef SpaceNumStr = Space.substr(5);
1596+
if (SpaceNumStr.getAsInteger(10, SpaceNum)) {
1597+
Diag(SpaceLoc, diag::err_hlsl_expected_space) << Space;
1598+
return;
16011599
}
16021600

16031601
// If we have slot, diagnose it is the right register type for the decl

0 commit comments

Comments
 (0)