Remove references to registry

Author: jofrn

llvm/include/llvm/Passes/PassBuilder.h

@@ -173,13 +173,6 @@ class PassBuilder {
   /// additional analyses.
   LLVM_ABI void registerLoopAnalyses(LoopAnalysisManager &LAM);
 
-  /// Registers all available verifier passes.
-  ///
-  /// This is an interface that can be used to populate a
-  /// \c ModuleAnalysisManager with all registered loop analyses. Callers can
-  /// still manually register any additional analyses.
-  void registerVerifierPasses(ModulePassManager &PM, FunctionPassManager &);
-
   /// Registers all available machine function analysis passes.
   ///
   /// This is an interface that can be used to populate a \c
@@ -583,15 +576,6 @@ class PassBuilder {
   }
   /// @}}
 
-  /// Register a callback for parsing an Verifier Name to populate
-  /// the given managers.
-  void registerVerifierCallback(
-      const std::function<bool(ModulePassManager &MPM)> &C,
-      const std::function<bool(FunctionPassManager &MPM)> &CF) {
-    VerifierCallbacks.push_back(C);
-    FnVerifierCallbacks.push_back(CF);
-  }
-
   /// {{@ Register pipeline parsing callbacks with this pass builder instance.
   /// Using these callbacks, callers can parse both a single pass name, as well
   /// as entire sub-pipelines, and populate the PassManager instance
@@ -867,11 +851,6 @@ class PassBuilder {
   // Callbacks to parse `filter` parameter in register allocation passes
   SmallVector<std::function<RegAllocFilterFunc(StringRef)>, 2>
       RegClassFilterParsingCallbacks;
-  // Verifier callbacks
-  SmallVector<std::function<bool(ModulePassManager &)>, 2>
-      VerifierCallbacks;
-  SmallVector<std::function<bool(FunctionPassManager &)>, 2>
-      FnVerifierCallbacks;
 };
 
 /// This utility template takes care of adding require<> and invalidate<>

llvm/include/llvm/Passes/StandardInstrumentations.h

@@ -624,7 +624,7 @@ class StandardInstrumentations {
   // Register all the standard instrumentation callbacks. If \p FAM is nullptr
   // then PreservedCFGChecker is not enabled.
   LLVM_ABI void registerCallbacks(PassInstrumentationCallbacks &PIC,
-                         ModuleAnalysisManager *MAM);
+                                  ModuleAnalysisManager *MAM);
 
   TimePassesHandler &getTimePasses() { return TimePasses; }
 };

llvm/include/llvm/Passes/TargetPassRegistry.inc

@@ -151,18 +151,6 @@ PB.registerPipelineParsingCallback([=](StringRef Name, FunctionPassManager &PM,
   return false;
 });
 
-PB.registerVerifierCallback([](ModulePassManager &PM) {
-#define VERIFIER_MODULE_ANALYSIS(NAME, CREATE_PASS) PM.addPass(CREATE_PASS)
-#include GET_PASS_REGISTRY
-#undef VERIFIER_MODULE_ANALYSIS
-  return false;
-}, [](FunctionPassManager &FPM) {
-#define VERIFIER_FUNCTION_ANALYSIS(NAME, CREATE_PASS) FPM.addPass(CREATE_PASS)
-#include GET_PASS_REGISTRY
-#undef VERIFIER_FUNCTION_ANALYSIS
-  return false;
-});
-
 #undef ADD_PASS
 #undef ADD_PASS_WITH_PARAMS
 

llvm/lib/Passes/PassBuilder.cpp

@@ -576,13 +576,6 @@ void PassBuilder::registerLoopAnalyses(LoopAnalysisManager &LAM) {
     C(LAM);
 }
 
-void PassBuilder::registerVerifierPasses(ModulePassManager &MPM, FunctionPassManager &FPM) {
-  for (auto &C : VerifierCallbacks)
-    C(MPM);
-  for (auto &C : FnVerifierCallbacks)
-    C(FPM);
-}
-
 static std::optional<std::pair<bool, bool>>
 parseFunctionPipelineName(StringRef Name) {
   std::pair<bool, bool> Params;

llvm/lib/Target/AMDGPU/AMDGPUPassRegistry.def

@@ -82,17 +82,6 @@ FUNCTION_ALIAS_ANALYSIS("amdgpu-aa", AMDGPUAA())
 #undef FUNCTION_ALIAS_ANALYSIS
 #undef FUNCTION_ANALYSIS
 
-#ifndef VERIFIER_MODULE_ANALYSIS
-#define VERIFIER_MODULE_ANALYSIS(NAME, CREATE_PASS)
-#endif
-#ifndef VERIFIER_FUNCTION_ANALYSIS
-#define VERIFIER_FUNCTION_ANALYSIS(NAME, CREATE_PASS)
-#endif
-VERIFIER_MODULE_ANALYSIS("verifier", VerifierPass())
-VERIFIER_FUNCTION_ANALYSIS("amdgpu-tgtverifier", AMDGPUTargetVerifierPass())
-#undef VERIFIER_MODULE_ANALYSIS
-#undef VERIFIER_FUNCTION_ANALYSIS
-
 #ifndef FUNCTION_PASS_WITH_PARAMS
 #define FUNCTION_PASS_WITH_PARAMS(NAME, CLASS, CREATE_PASS, PARSER, PARAMS)
 #endif

llvm/tools/llc/NewPMDriver.cpp

@@ -57,9 +57,6 @@ static cl::opt<bool>
     DebugPM("debug-pass-manager", cl::Hidden,
             cl::desc("Print pass management debugging information"));
 
-static cl::opt<bool> VerifyTarget("verify-tgt-new-pm",
-		                  cl::desc("Verify the target"));
-
 bool LLCDiagnosticHandler::handleDiagnostics(const DiagnosticInfo &DI) {
   DiagnosticHandler::handleDiagnostics(DI);
   if (DI.getKind() == llvm::DK_SrcMgr) {
@@ -128,8 +125,6 @@ int llvm::compileModuleWithNewPM(
   PB.registerFunctionAnalyses(FAM);
   PB.registerLoopAnalyses(LAM);
   PB.registerMachineFunctionAnalyses(MFAM);
-  if (VerifyTarget)
-    PB.registerVerifierPasses(MPM, FPM);
   PB.crossRegisterProxies(LAM, FAM, CGAM, MAM, &MFAM);
   SI.registerCallbacks(PIC, &MAM);
 

llvm/tools/llc/llc.cpp

@@ -209,8 +209,6 @@ static cl::opt<std::string> PassPipeline(
 static cl::alias PassPipeline2("p", cl::aliasopt(PassPipeline),
                                cl::desc("Alias for -passes"));
 
-static cl::opt<bool> VerifyTarget("verify-tgt", cl::desc("Verify the target"));
-
 namespace {
 
 std::vector<std::string> &getRunPassNames() {