Skip to content

Commit c7f0750

Browse files
committed
remove some untested checks
1 parent df59fe9 commit c7f0750

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

flang/lib/Semantics/check-acc-structure.cpp

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -365,14 +365,14 @@ void AccStructureChecker::CheckAtomicStmt(
365365
context_.Say(expr.source,
366366
"LHS of atomic %s statement must be scalar"_err_en_US, construct);
367367
}
368-
// TODO: Check if lhs is intrinsic type
368+
// TODO: Check if lhs is intrinsic type.
369369
}
370370
if (rhs) {
371371
if (rhs->Rank() != 0) {
372372
context_.Say(var.GetSource(),
373373
"RHS of atomic %s statement must be scalar"_err_en_US, construct);
374374
}
375-
// TODO: Check if rhs is intrinsic type
375+
// TODO: Check if rhs is intrinsic type.
376376
}
377377
}
378378

@@ -445,12 +445,6 @@ void AccStructureChecker::CheckAtomicUpdateStmt(
445445
"Arguments to the atomic update operation cannot reference the updated variable, %s, as a subexpression"_err_en_US,
446446
updateVar.AsFortran());
447447
}
448-
// TODO:
449-
// if (captureVar && omp::IsSubexpressionOf(*captureVar, arg)) {
450-
// context_.Say(expr.source,
451-
// "The RHS of this atomic update statement cannot reference the
452-
// capture variable: %s"_err_en_US, captureVar->AsFortran());
453-
//}
454448
}
455449
if (!foundUpdateVar) {
456450
context_.Say(expr.source,
@@ -474,13 +468,6 @@ void AccStructureChecker::CheckAtomicWriteStmt(
474468
"The RHS of this atomic write statement cannot reference the atomic variable: %s"_err_en_US,
475469
updateVar.AsFortran());
476470
}
477-
// TODO fix tests that this breaks.
478-
// if (captureVar && omp::IsSubexpressionOf(*captureVar, *rhs)) {
479-
// context_.Say(expr.source,
480-
// "The RHS of this atomic write statement cannot reference the
481-
// variable, %s, used to capture the atomic variable"_err_en_US,
482-
// captureVar->AsFortran());
483-
//}
484471
}
485472
}
486473

0 commit comments

Comments
 (0)