Skip to content

Commit c8afc6a

Browse files
committed
[libc++] Fix a few incorrect find-and-replace in the %{temp} change
1 parent 6e784af commit c8afc6a

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

libcxx/test/benchmarks/spec.gen.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,18 @@
6666

6767
for benchmark in spec_benchmarks:
6868
print(f'#--- {benchmark}.sh.test')
69-
print(f'RUN: rm -rf %{temp}') # clean up any previous (potentially incomplete) run
70-
print(f'RUN: mkdir %{temp}')
71-
print(f'RUN: cp {spec_config} %{temp}/spec-config.cfg')
72-
print(f'RUN: %{{spec_dir}}/bin/runcpu --config %{temp}/spec-config.cfg --size train --output-root %{temp} --rebuild {benchmark}')
73-
print(f'RUN: rm -rf %{temp}/benchspec') # remove the temporary directory, which can become quite large
69+
print(f'RUN: rm -rf %{{temp}}') # clean up any previous (potentially incomplete) run
70+
print(f'RUN: mkdir %{{temp}}')
71+
print(f'RUN: cp {spec_config} %{{temp}}/spec-config.cfg')
72+
print(f'RUN: %{{spec_dir}}/bin/runcpu --config %{{temp}}/spec-config.cfg --size train --output-root %{{temp}} --rebuild {benchmark}')
73+
print(f'RUN: rm -rf %{{temp}}/benchspec') # remove the temporary directory, which can become quite large
7474

7575
# The `runcpu` command above doesn't fail even if the benchmark fails to run. To determine failure, parse the CSV
7676
# results and ensure there are no compilation errors or runtime errors in the status row. Also print the logs and
7777
# fail if there are no CSV files at all, which implies a SPEC error.
78-
print(f'RUN: %{{libcxx-dir}}/utils/parse-spec-results --extract "Base Status" --keep-failed %{temp}/result/*.train.csv > %{temp}/status || ! cat %{temp}/result/*.log')
79-
print(f'RUN: ! grep -E "CE|RE" %{temp}/status || ! cat %{temp}/result/*.log')
78+
print(f'RUN: %{{libcxx-dir}}/utils/parse-spec-results --extract "Base Status" --keep-failed %{{temp}}/result/*.train.csv > %{{temp}}/status || ! cat %{{temp}}/result/*.log')
79+
print(f'RUN: ! grep -E "CE|RE" %{{temp}}/status || ! cat %{{temp}}/result/*.log')
8080

8181
# If there were no errors, parse the results into LNT-compatible format and print them.
82-
print(f'RUN: %{{libcxx-dir}}/utils/parse-spec-results %{temp}/result/*.train.csv --output-format=lnt > %{temp}/results.lnt')
83-
print(f'RUN: cat %{temp}/results.lnt')
82+
print(f'RUN: %{{libcxx-dir}}/utils/parse-spec-results %{{temp}}/result/*.train.csv --output-format=lnt > %{{temp}}/results.lnt')
83+
print(f'RUN: cat %{{temp}}/results.lnt')

libcxx/utils/test-at-commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ config.substitutions.append(('%{{flags}}',
2222
))
2323
config.substitutions.append(('%{{compile_flags}}', '-nostdinc++ -I {INSTALL_ROOT}/include/c++/v1 -I %{{libcxx-dir}}/test/support'))
2424
config.substitutions.append(('%{{link_flags}}', '-nostdlib++ -L {INSTALL_ROOT}/lib -Wl,-rpath,{INSTALL_ROOT}/lib -lc++'))
25-
config.substitutions.append(('%{{exec}}', '%{{executor}} --execdir %{temp} -- '))
25+
config.substitutions.append(('%{{exec}}', '%{{executor}} --execdir %{{temp}} -- '))
2626
2727
import os, site
2828
site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils'))

0 commit comments

Comments
 (0)