Avoiding else after return

elijahkin · web-flow · commit c8b3e811002a · 2025-07-09T16:46:58.000-07:00
diff --git a/llvm/include/llvm/ADT/DenseMapInfo.h b/llvm/include/llvm/ADT/DenseMapInfo.h
@@ -341,12 +341,10 @@ struct DenseMapInfo<std::optional<T>> {
   }
 
   static bool isEqual(const Optional &LHS, const Optional &RHS) {
-    if (LHS.has_value() && RHS.has_value()) {
+    if (LHS && RHS) {
       return Info::isEqual(LHS.value(), RHS.value());
-    } else if (!LHS.has_value() && !RHS.has_value()) {
-      return true;
     }
-    return false;
+    return !LHS && !RHS;
   }
 };
 } // end namespace llvm

Original file line number	Diff line number	Diff line change
`@@ -341,12 +341,10 @@ struct DenseMapInfo<std::optional<T>> {`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`static bool isEqual(const Optional &LHS, const Optional &RHS) {`
`344`		`- if (LHS.has_value() && RHS.has_value()) {`
	`344`	`+ if (LHS && RHS) {`
`345`	`345`	`return Info::isEqual(LHS.value(), RHS.value());`
`346`		`- } else if (!LHS.has_value() && !RHS.has_value()) {`
`347`		`- return true;`
`348`	`346`	`}`
`349`		`- return false;`
	`347`	`+ return !LHS && !RHS;`
`350`	`348`	`}`
`351`	`349`	`};`
`352`	`350`	`} // end namespace llvm`