address comments

alexey-bataev · alexey-bataev · commit c911b47b2538 · 2025-07-17T11:59:36.000Z
Created using spr 1.3.5
diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -11776,6 +11776,9 @@ void BoUpSLP::transformNodes() {
           }
           Slices.emplace_back(Cnt, Slice.size());
         }
+        // Do not try to vectorize if all slides are strided or gathered with
+        // vector factor 2 and there are more than 2 slices. Better to handle
+        // them in gathered loads analysis, may result in better vectorization.
         if (VF == 2 && AllStrided && Slices.size() > 2)
           continue;
         auto AddCombinedNode = [&](unsigned Idx, unsigned Cnt, unsigned Sz) {

Original file line number	Diff line number	Diff line change
`@@ -11776,6 +11776,9 @@ void BoUpSLP::transformNodes() {`
`11776`	`11776`	`}`
`11777`	`11777`	`Slices.emplace_back(Cnt, Slice.size());`
`11778`	`11778`	`}`
	`11779`	`+ // Do not try to vectorize if all slides are strided or gathered with`
	`11780`	`+ // vector factor 2 and there are more than 2 slices. Better to handle`
	`11781`	`+ // them in gathered loads analysis, may result in better vectorization.`
`11779`	`11782`	`if (VF == 2 && AllStrided && Slices.size() > 2)`
`11780`	`11783`	`continue;`
`11781`	`11784`	`auto AddCombinedNode = [&](unsigned Idx, unsigned Cnt, unsigned Sz) {`