[test] false positive is fixed

Author: gamesh411

clang/test/Analysis/block-in-critical-section.cpp

@@ -294,19 +294,13 @@ void testBlockInCriticalSectionUniqueLockNested() {
   sleep(1); // no-warning
 }
 
-void testTrylockCurrentlyFalsePositive(pthread_mutex_t *m) {
-                                       // expected-note@+4 {{Assuming the condition is true}}
-                                       // expected-note@+3 {{Taking true branch}}
-                                       // expected-note@+2 {{Assuming the condition is false}}
-                                       // expected-note@+1 {{Taking false branch}}
-  if (pthread_mutex_trylock(m) == 0) { // expected-note 2 {{Entering critical section here}}
-                                       // FIXME: we are entering the critical section only in the true branch
+void testTrylockStateSplitting(pthread_mutex_t *m) {
+                                       // expected-note@+1 {{Taking true branch}}
+  if (pthread_mutex_trylock(m) == 0) { // expected-note {{Entering critical section here}}
     sleep(10); // expected-warning {{Call to blocking function 'sleep' inside of critical section}}
                // expected-note@-1 {{Call to blocking function 'sleep' inside of critical section}}
     pthread_mutex_unlock(m);
   } else {
-    sleep(10); // expected-warning {{Call to blocking function 'sleep' inside of critical section}}
-               // expected-note@-1 {{Call to blocking function 'sleep' inside of critical section}}
-               // FIXME: this is a false positive, the lock was not acquired
+    sleep(10); // no-warning
   }
 }