Address arsenm's comment

tclin914 · tclin914 · commit c94af5dddeb4 · 2025-02-12T09:18:40.000+08:00
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -9702,7 +9702,7 @@ SDValue DAGCombiner::visitXOR(SDNode *N) {
   }
 
   // fold (not (add X, -1)) -> (neg X)
-  if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::ADD && N0.hasOneUse() &&
+  if (N0.getOpcode() == ISD::ADD && N0.hasOneUse() && isAllOnesConstant(N1) &&
       isAllOnesOrAllOnesSplat(N0.getOperand(1))) {
     return DAG.getNegative(N0.getOperand(0), DL, VT);
   }

Original file line number	Diff line number	Diff line change
`@@ -9702,7 +9702,7 @@ SDValue DAGCombiner::visitXOR(SDNode *N) {`
`9702`	`9702`	`}`
`9703`	`9703`
`9704`	`9704`	`// fold (not (add X, -1)) -> (neg X)`
`9705`		`- if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::ADD && N0.hasOneUse() &&`
	`9705`	`+ if (N0.getOpcode() == ISD::ADD && N0.hasOneUse() && isAllOnesConstant(N1) &&`
`9706`	`9706`	`isAllOnesOrAllOnesSplat(N0.getOperand(1))) {`
`9707`	`9707`	`return DAG.getNegative(N0.getOperand(0), DL, VT);`
`9708`	`9708`	`}`