Address review comments

Add a note in the release notes about the fix for the no-return function warning

Author: snarang181

clang/docs/ReleaseNotes.rst

@@ -648,6 +648,12 @@ Improvements to Clang's diagnostics
   #GH69470, #GH59391, #GH58172, #GH46215, #GH45915, #GH45891, #GH44490,
   #GH36703, #GH32903, #GH23312, #GH69874.
 
+- Clang no longer warns about missing return statements (-Wreturn-type)
+  if the final statement of a non-void function is a `throw` expression
+  or a call to a function that is known to always throw. This avoids
+  false positives in code patterns where control flow is intentionally
+  terminated via exceptions.
+
 
 Improvements to Clang's time-trace
 ----------------------------------

clang/lib/Sema/AnalysisBasedWarnings.cpp

@@ -643,10 +643,7 @@ bool isKnownToAlwaysThrow(const FunctionDecl *FD) {
     OnlyStmt = EWC->getSubExpr();
   }
   // Check if the only statement is a throw expression.
-  if (isa<CXXThrowExpr>(OnlyStmt)) {
-    return true; // Known to always throw.
-  }
-  return false; // Not known to always throw.
+  return isa<CXXThrowExpr>(OnlyStmt);
 }
 
 } // anonymous namespace
@@ -708,25 +705,23 @@ static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
       // If the final statement is a call to an always-throwing function,
       // don't warn about the fall-through.
       if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
-        if (const auto *CS = dyn_cast<CompoundStmt>(Body)) {
-          if (!CS->body_empty()) {
-            const Stmt *LastStmt = CS->body_back();
-            // Unwrap ExprWithCleanups if necessary.
-            if (const auto *EWC = dyn_cast<ExprWithCleanups>(LastStmt)) {
-              LastStmt = EWC->getSubExpr();
-            }
-            if (const auto *CE = dyn_cast<CallExpr>(LastStmt)) {
-              if (const FunctionDecl *Callee = CE->getDirectCallee()) {
-                if (isKnownToAlwaysThrow(Callee)) {
-                  return; // Don't warn about fall-through.
-                }
-              }
-            }
-            // Direct throw.
-            if (isa<CXXThrowExpr>(LastStmt)) {
+        if (const auto *CS = dyn_cast<CompoundStmt>(Body);
+            CS && !CS->body_empty()) {
+          const Stmt *LastStmt = CS->body_back();
+          // Unwrap ExprWithCleanups if necessary.
+          if (const auto *EWC = dyn_cast<ExprWithCleanups>(LastStmt)) {
+            LastStmt = EWC->getSubExpr();
+          }
+          if (const auto *CE = dyn_cast<CallExpr>(LastStmt)) {
+            if (const FunctionDecl *Callee = CE->getDirectCallee();
+                Callee && isKnownToAlwaysThrow(Callee)) {
               return; // Don't warn about fall-through.
             }
           }
+          // Direct throw.
+          if (isa<CXXThrowExpr>(LastStmt)) {
+            return; // Don't warn about fall-through.
+          }
         }
       }
       bool NotInAllControlPaths = FallThroughType == MaybeFallThrough;