Skip to content

Commit c9d50d1

Browse files
committed
emphasise need to ask for merge
1 parent 9ac58df commit c9d50d1

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

llvm/docs/Contributing.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,13 @@ other professional developers.
114114
After your PR is approved, ensure that:
115115

116116
* The PR title and description describe the final changes. These will be used
117-
as the title and message of the final squashed commit. The titles or
118-
messages of any commits in the PR will **not** be used.
117+
as the title and message of the final squashed commit. The titles and
118+
messages of commits in the PR will **not** be used.
119119
* You have set a valid email address in your GitHub account, see :ref:`github-email-address`.
120120

121121
Now you can merge your PR. If you do not have the ability to merge the PR, ask your
122-
reviewers to merge it on your behalf.
122+
reviewers to merge it on your behalf. You must do this explicitly, as reviewers'
123+
default assumption is that you are able to merge your own PR.
123124

124125
For more information on LLVM's code-review process, please see
125126
:doc:`CodeReview`.

0 commit comments

Comments
 (0)