cleanup

Revert "add logs for tracing"
Revert "application test"

Author: kikairoya

lld/COFF/Chunks.cpp

@@ -566,11 +566,6 @@ void SectionChunk::getBaserels(std::vector<Baserel> *res) {
     Symbol *target = file->getSymbol(rel.SymbolTableIndex);
     if (!isa_and_nonnull<Defined>(target) || isa<DefinedAbsolute>(target))
       continue;
-    if (target && target->getName().size() > 2)
-      Log(file->symtab.ctx)
-          << "base reloc for " << target->getName() << ": " << target->kind()
-          << ',' << !!target->isUsedInRegularObj << " (in " << file->getName()
-          << ")";
     res->emplace_back(rva + rel.VirtualAddress, ty);
   }
 

lld/COFF/MinGW.cpp

@@ -226,8 +226,6 @@ void lld::coff::addWrappedSymbols(SymbolTable &symtab,
     Symbol *sym = symtab.findUnderscore(name);
     if (!sym)
       continue;
-    Log(symtab.ctx) << "adding wrapped symbol entry for: " << name << ": "
-                    << sym->kind() << ',' << !!sym->isUsedInRegularObj;
 
     Symbol *real =
         symtab.addUndefined(mangle("__real_" + name, symtab.machine));
@@ -238,12 +236,10 @@ void lld::coff::addWrappedSymbols(SymbolTable &symtab,
     if (auto *usym = dyn_cast<Undefined>(sym)) {
       if (auto *ureal = dyn_cast<Undefined>(real);
           ureal && ureal->weakAlias && !usym->weakAlias) {
-        Log(symtab.ctx) << "inheriting weak alias to: " << usym->getName();
         usym->weakAlias = ureal->weakAlias;
       }
       if (auto *uwrap = dyn_cast<Undefined>(wrap);
           uwrap && usym->weakAlias && !uwrap->weakAlias) {
-        Log(symtab.ctx) << "inheriting weak alias to: " << uwrap->getName();
         uwrap->weakAlias = usym->weakAlias;
       }
     }
@@ -278,8 +274,6 @@ void lld::coff::wrapSymbols(SymbolTable &symtab) {
     map[w.sym] = w.wrap;
     map[w.real] = w.sym;
     if (Defined *d = dyn_cast<Defined>(w.wrap)) {
-      Log(symtab.ctx) << "checking for importing with unwrapping: "
-                      << d->getName();
       Symbol *imp = symtab.find(("__imp_" + w.sym->getName()).str());
       // Create a new defined local import for the wrap symbol. If
       // no imp prefixed symbol existed, there's no need for it.
@@ -288,12 +282,8 @@ void lld::coff::wrapSymbols(SymbolTable &symtab) {
       if (imp) {
         if (Symbol *wrapimp =
                 symtab.find(("__imp_" + w.wrap->getName()).str())) {
-          Log(symtab.ctx) << "using unwrapped imported symbol: "
-                          << imp->getName();
           map[imp] = wrapimp;
         } else {
-          Log(symtab.ctx) << "create local unwrapped imported symbol: "
-                          << imp->getName();
           DefinedLocalImport *localwrapimp = make<DefinedLocalImport>(
               symtab.ctx, saver().save("__imp_" + w.wrap->getName()), d);
           symtab.localImportChunks.push_back(localwrapimp->getChunk());
@@ -307,10 +297,7 @@ void lld::coff::wrapSymbols(SymbolTable &symtab) {
   parallelForEach(symtab.ctx.objFileInstances, [&](ObjFile *file) {
     MutableArrayRef<Symbol *> syms = file->getMutableSymbols();
     for (auto &sym : syms)
-      if (Symbol *s = map.lookup(sym)) {
-        Log(symtab.ctx) << "overriding " << sym->getName() << " by "
-                        << s->getName() << " (in " << file->getName() << ")";
+      if (Symbol *s = map.lookup(sym))
         sym = s;
-      }
   });
 }

lld/COFF/SymbolTable.cpp

@@ -257,8 +257,6 @@ void SymbolTable::loadMinGWSymbols() {
   }
 
   for (auto sym : undefs) {
-    Log(ctx) << "trying fixup " << sym->getName() << ": " << sym->kind() << ','
-             << !!sym->isUsedInRegularObj;
     auto *undef = dyn_cast<Undefined>(sym);
     if (!undef)
       continue;
@@ -461,13 +459,6 @@ void SymbolTable::resolveRemainingUndefines(std::vector<Undefined *> &aliases) {
 
   for (auto &i : symMap) {
     Symbol *sym = i.second;
-
-    if (auto name = sym->getName(); !name.ends_with("__") &&
-                                    !name.starts_with("__guard") &&
-                                    !name.starts_with("__nm_"))
-      Log(ctx) << "checking for " << name << ": " << sym->kind()
-               << " used: " << (sym->isUsedInRegularObj != 0);
-
     auto *undef = dyn_cast<Undefined>(sym);
     if (!undef)
       continue;
@@ -534,7 +525,6 @@ void SymbolTable::resolveRemainingUndefines(std::vector<Undefined *> &aliases) {
 }
 
 std::pair<Symbol *, bool> SymbolTable::insert(StringRef name) {
-  Log(ctx) << "inserting " << name;
   bool inserted = false;
   Symbol *&sym = symMap[CachedHashStringRef(name)];
   if (!sym) {

lld/COFF/Symbols.h

@@ -56,7 +56,7 @@ class Symbol {
     DefinedAbsoluteKind,
     DefinedSyntheticKind,
 
-    UndefinedKind, // = 7
+    UndefinedKind,
     LazyArchiveKind,
     LazyObjectKind,
     LazyDLLSymbolKind,

lld/COFF/Writer.cpp

@@ -1299,7 +1299,6 @@ void Writer::createImportTables() {
                    << file->symtab.printSymbol(impSym);
       delayIdata.add(impSym);
     } else {
-      Log(ctx) << "populating import entry for " << impSym->getName();
       idata.add(impSym);
     }
   }