Skip to content

Commit cae73be

Browse files
authored
[LLDB][PDB] Fix plugin warning message style (#160398)
Makes the warning message conform to the [LLVM error and warning style](https://llvm.org/docs/CodingStandards.html#error-and-warning-messages) as mentioned in #160067 (comment).
1 parent 094d313 commit cae73be

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ class PluginProperties : public Properties {
139139
if (!IsNativeReaderRequested()) {
140140
static std::once_flag g_warning_shown;
141141
Debugger::ReportWarning(
142-
"The DIA PDB reader was explicitly requested, but LLDB was built "
143-
"without the DIA SDK. The native reader will be used instead.",
142+
"the DIA PDB reader was explicitly requested, but LLDB was built "
143+
"without the DIA SDK. The native reader will be used instead",
144144
{}, &g_warning_shown);
145145
}
146146
return true;

lldb/test/Shell/SymbolFile/NativePDB/native-setting.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
// NO-ENV: Dumping debug symbols for 1 modules.
3939
// NO-ENV: SymbolFile native-pdb
4040

41-
// ENV0: warning: The DIA PDB reader was explicitly requested, but LLDB was built without the DIA SDK. The native reader will be used instead.
41+
// ENV0: warning: the DIA PDB reader was explicitly requested, but LLDB was built without the DIA SDK. The native reader will be used instead
4242
// ENV0: (lldb) target modules dump symfile
4343
// ENV0: Dumping debug symbols for 1 modules.
4444
// ENV0: SymbolFile native-pdb
@@ -48,12 +48,12 @@
4848
// ENV1: Dumping debug symbols for 1 modules.
4949
// ENV1: SymbolFile native-pdb
5050

51-
// ENV0-SET-DIA: warning: The DIA PDB reader was explicitly requested, but LLDB was built without the DIA SDK. The native reader will be used instead.
51+
// ENV0-SET-DIA: warning: the DIA PDB reader was explicitly requested, but LLDB was built without the DIA SDK. The native reader will be used instead
5252
// ENV0-SET-DIA: (lldb) target modules dump symfile
5353
// ENV0-SET-DIA: Dumping debug symbols for 1 modules.
5454
// ENV0-SET-DIA: SymbolFile native-pdb
5555

56-
// ENV1-SET-DIA: warning: The DIA PDB reader was explicitly requested, but LLDB was built without the DIA SDK. The native reader will be used instead.
56+
// ENV1-SET-DIA: warning: the DIA PDB reader was explicitly requested, but LLDB was built without the DIA SDK. The native reader will be used instead
5757
// ENV1-SET-DIA: (lldb) target modules dump symfile
5858
// ENV1-SET-DIA: Dumping debug symbols for 1 modules.
5959
// ENV1-SET-DIA: SymbolFile native-pdb

0 commit comments

Comments
 (0)