Feedback

Author: dcaballe

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

@@ -2000,15 +2000,16 @@ struct VectorToElementsLowering
     SmallVector<Value> results(toElementsOp->getNumResults());
     for (auto [idx, element] : llvm::enumerate(toElementsOp.getElements())) {
       // Create an extractelement operation only for results that are not dead.
-      if (!element.use_empty()) {
-        auto constIdx = rewriter.create<LLVM::ConstantOp>(
-            loc, idxType, rewriter.getIntegerAttr(idxType, idx));
-        auto llvmType = typeConverter->convertType(element.getType());
-
-        Value result = rewriter.create<LLVM::ExtractElementOp>(
-            loc, llvmType, source, constIdx);
-        results[idx] = result;
-      }
+      if (element.use_empty())
+        continue;
+
+      auto constIdx = rewriter.create<LLVM::ConstantOp>(
+          loc, idxType, rewriter.getIntegerAttr(idxType, idx));
+      auto llvmType = typeConverter->convertType(element.getType());
+
+      Value result = rewriter.create<LLVM::ExtractElementOp>(loc, llvmType,
+                                                             source, constIdx);
+      results[idx] = result;
     }
 
     rewriter.replaceOp(toElementsOp, results);

mlir/test/Conversion/VectorToLLVM/vector-to-llvm-interface.mlir

@@ -2421,7 +2421,11 @@ func.func @from_elements_0d(%arg0: f32) -> vector<f32> {
 
 // -----
 
-// CHECK-LABEL: func.func @vector_to_elements_no_dead_elements
+//===----------------------------------------------------------------------===//
+// vector.to_elements
+//===----------------------------------------------------------------------===//
+
+// CHECK-LABEL: func.func @to_elements_no_dead_elements
  // CHECK-SAME:     %[[A:.*]]: vector<4xf32>)
  //      CHECK:   %[[C0:.*]] = llvm.mlir.constant(0 : i64) : i64
  //      CHECK:   %[[ELEM0:.*]] = llvm.extractelement %[[A]][%[[C0]] : i64] : vector<4xf32>
@@ -2432,14 +2436,14 @@ func.func @from_elements_0d(%arg0: f32) -> vector<f32> {
  //      CHECK:   %[[C3:.*]] = llvm.mlir.constant(3 : i64) : i64
  //      CHECK:   %[[ELEM3:.*]] = llvm.extractelement %[[A]][%[[C3]] : i64] : vector<4xf32>
  //      CHECK:   return %[[ELEM0]], %[[ELEM1]], %[[ELEM2]], %[[ELEM3]] : f32, f32, f32, f32
-func.func @vector_to_elements_no_dead_elements(%a: vector<4xf32>) -> (f32, f32, f32, f32) {
+func.func @to_elements_no_dead_elements(%a: vector<4xf32>) -> (f32, f32, f32, f32) {
   %0:4 = vector.to_elements %a : vector<4xf32>
   return %0#0, %0#1, %0#2, %0#3 : f32, f32, f32, f32
 }
 
 // -----
 
-// CHECK-LABEL: func.func @vector_to_elements_dead_elements
+// CHECK-LABEL: func.func @to_elements_dead_elements
  // CHECK-SAME:     %[[A:.*]]: vector<4xf32>)
  //  CHECK-NOT:   llvm.mlir.constant(0 : i64) : i64
  //      CHECK:   %[[C1:.*]] = llvm.mlir.constant(1 : i64) : i64
@@ -2448,7 +2452,7 @@ func.func @vector_to_elements_no_dead_elements(%a: vector<4xf32>) -> (f32, f32,
  //      CHECK:   %[[C3:.*]] = llvm.mlir.constant(3 : i64) : i64
  //      CHECK:   %[[ELEM3:.*]] = llvm.extractelement %[[A]][%[[C3]] : i64] : vector<4xf32>
  //      CHECK:   return %[[ELEM1]], %[[ELEM3]] : f32, f32
-func.func @vector_to_elements_dead_elements(%a: vector<4xf32>) -> (f32, f32) {
+func.func @to_elements_dead_elements(%a: vector<4xf32>) -> (f32, f32) {
   %0:4 = vector.to_elements %a : vector<4xf32>
   return %0#1, %0#3 : f32, f32
 }