Skip to content

Commit cc5afae

Browse files
author
joaosaffran
committed
address changes
1 parent c7d5be7 commit cc5afae

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

llvm/lib/Target/DirectX/DXILRootSignature.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -556,10 +556,7 @@ AnalysisKey RootSignatureAnalysis::Key;
556556

557557
RootSignatureAnalysis::Result
558558
RootSignatureAnalysis::run(Module &M, ModuleAnalysisManager &AM) {
559-
if (!AnalysisResult)
560-
AnalysisResult = std::make_unique<RootSignatureBindingInfo>(
561-
RootSignatureBindingInfo(analyzeModule(M)));
562-
return *AnalysisResult;
559+
return RootSignatureBindingInfo(analyzeModule(M));
563560
}
564561

565562
//===----------------------------------------------------------------------===//
@@ -638,15 +635,14 @@ PreservedAnalyses RootSignatureAnalysisPrinter::run(Module &M,
638635

639636
//===----------------------------------------------------------------------===//
640637
bool RootSignatureAnalysisWrapper::runOnModule(Module &M) {
641-
if (!FuncToRsMap)
642-
FuncToRsMap = std::make_unique<RootSignatureBindingInfo>(
643-
RootSignatureBindingInfo(analyzeModule(M)));
638+
FuncToRsMap = std::make_unique<RootSignatureBindingInfo>(
639+
RootSignatureBindingInfo(analyzeModule(M)));
644640
return false;
645641
}
646642

647643
void RootSignatureAnalysisWrapper::getAnalysisUsage(AnalysisUsage &AU) const {
648644
AU.setPreservesAll();
649-
AU.addRequired<DXILMetadataAnalysisWrapperPass>();
645+
AU.addPreserved<DXILMetadataAnalysisWrapperPass>();
650646
}
651647

652648
char RootSignatureAnalysisWrapper::ID = 0;

llvm/lib/Target/DirectX/DXILRootSignature.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ class RootSignatureAnalysis : public AnalysisInfoMixin<RootSignatureAnalysis> {
7373
using Result = RootSignatureBindingInfo;
7474

7575
Result run(Module &M, ModuleAnalysisManager &AM);
76-
77-
private:
78-
std::unique_ptr<RootSignatureBindingInfo> AnalysisResult;
7976
};
8077

8178
/// Wrapper pass for the legacy pass manager.

0 commit comments

Comments
 (0)