[lldb] Remove redundant declarations (NFC) (#169003)

kazutakahirata · web-flow · commit cc7e2067b1a0 · 2025-11-21T20:31:54.000-08:00
In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.

Identified with readability-redundant-declaration.
diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp
@@ -156,8 +156,6 @@ static Status installExecutable(const Installer &installer) {
   return Status();
 }
 
-constexpr std::chrono::milliseconds EvaluateExpressionOptions::default_timeout;
-
 Target::Arch::Arch(const ArchSpec &spec)
     : m_spec(spec),
       m_plugin_up(PluginManager::CreateArchitectureInstance(spec)) {}
diff --git a/lldb/source/Utility/StringExtractorGDBRemote.cpp b/lldb/source/Utility/StringExtractorGDBRemote.cpp
@@ -12,9 +12,6 @@
 #include <cstring>
 #include <optional>
 
-constexpr lldb::pid_t StringExtractorGDBRemote::AllProcesses;
-constexpr lldb::tid_t StringExtractorGDBRemote::AllThreads;
-
 StringExtractorGDBRemote::ResponseType
 StringExtractorGDBRemote::GetResponseType() const {
   if (m_packet.empty())

Original file line number	Diff line number	Diff line change
`@@ -156,8 +156,6 @@ static Status installExecutable(const Installer &installer) {`
`156`	`156`	`return Status();`
`157`	`157`	`}`
`158`	`158`
`159`		`-constexpr std::chrono::milliseconds EvaluateExpressionOptions::default_timeout;`
`160`		`-`
`161`	`159`	`Target::Arch::Arch(const ArchSpec &spec)`
`162`	`160`	`: m_spec(spec),`
`163`	`161`	`m_plugin_up(PluginManager::CreateArchitectureInstance(spec)) {}`