fails largely because of constexpr limit, because for Container<int, MoveOnly> c, issues happen similar to move_alloc move_assign

Author: vinay-deshmukh

libcxx/include/__memory/pointer_traits.h

@@ -255,7 +255,7 @@ concept __resettable_smart_pointer_with_args = requires(_Smart __s, _Pointer __p
 // This function ensures safe conversions between fancy pointers at compile-time, where we avoid casts from/to
 // `__void_pointer` by obtaining the underlying raw pointer from the fancy pointer using `std::to_address`,
 // then dereferencing it to retrieve the pointed-to object, and finally constructing the target fancy pointer
-// to that object using the `std::pointer_traits<>::pinter_to` function.
+// to that object using the `std::pointer_traits<>::pointer_to` function.
 template <class _PtrTo, class _PtrFrom>
 _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI _PtrTo __static_fancy_pointer_cast(const _PtrFrom& __p) {
   using __ptr_traits   = pointer_traits<_PtrTo>;

libcxx/include/__tree

@@ -911,7 +911,13 @@ private:
 
 public:
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX26 __node_pointer __root() const _NOEXCEPT {
+    // double t = __end_node()->__left_;
+    using __ptr_traits   = pointer_traits<__node_pointer>;
+    using __element_type = typename __ptr_traits::element_type;
+typename __element_type_type x{};
+    double t = x;
     return std::__static_fancy_pointer_cast<__node_pointer>(__end_node()->__left_);
+    // return static_cast<__node_pointer>(__end_node()->__left_);
   }
 
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX26 __node_base_pointer* __root_ptr() const _NOEXCEPT {

libcxx/test/std/containers/associative/map/map.modifiers/insert_range.pass.cpp

@@ -34,8 +34,10 @@ TEST_CONSTEXPR_CXX26 bool test() {
 
   test_map_insert_range_move_only<std::map>();
 
+#ifndef TEST_IS_CONSTANT_EVALUATED
   test_map_insert_range_exception_safety_throwing_copy<std::map>();
   test_assoc_map_insert_range_exception_safety_throwing_allocator<std::map, int, int>();
+#endif
   return true;
 }
 

libcxx/test/std/containers/insert_range_maps_sets.h

@@ -259,13 +259,14 @@ void test_set_insert_range_move_only() {
 }
 
 template <template <class...> class Container>
-void test_map_insert_range_move_only() {
+TEST_CONSTEXPR_CXX26 bool test_map_insert_range_move_only() {
   using Value = std::pair<const int, MoveOnly>;
   Value input[5];
   std::ranges::subrange in(std::move_iterator{input}, std::move_iterator{input + 5});
 
   Container<int, MoveOnly> c;
   c.insert_range(in);
+  return true;
 }
 
 // Exception safety.