Skip to content

Commit cd1acf2

Browse files
authored
[mlir][Transforms] Remove UB dialect dependency from Canonicalizer pass (#150555)
The Canonicalizer pass has a dependency to UB dialect which shouldn't have. It also no longer needs to directly depend on the UB dialect since the Vector dialect (which uses UB dialect for poison index operations introduced by 35df525) already declares this dependency(878d359).
1 parent ae36702 commit cd1acf2

File tree

4 files changed

+1
-3
lines changed

4 files changed

+1
-3
lines changed

mlir/include/mlir/Transforms/Passes.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ def Canonicalizer : Pass<"canonicalize"> {
2828
details.
2929
}];
3030
let constructor = "mlir::createCanonicalizerPass()";
31-
let dependentDialects = ["ub::UBDialect"];
3231
let options = [
3332
Option<"topDownProcessingEnabled", "top-down", "bool",
3433
/*default=*/"true",

mlir/lib/Dialect/Vector/IR/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ add_mlir_dialect_library(MLIRVectorDialect
2626
MLIRMemRefDialect
2727
MLIRSideEffectInterfaces
2828
MLIRTensorDialect
29+
MLIRUBDialect
2930
MLIRValueBoundsOpInterface
3031
MLIRVectorInterfaces
3132
)

mlir/lib/Transforms/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,4 @@ add_mlir_library(MLIRTransforms
3737
MLIRSideEffectInterfaces
3838
MLIRSupport
3939
MLIRTransformUtils
40-
MLIRUBDialect
4140
)

mlir/lib/Transforms/Canonicalizer.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
#include "mlir/Transforms/Passes.h"
1515

16-
#include "mlir/Dialect/UB/IR/UBOps.h"
1716
#include "mlir/Pass/Pass.h"
1817
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
1918

0 commit comments

Comments
 (0)