self-review: fix-up comments

Author: Finn Plummer

clang/include/clang/Parse/ParseHLSLRootSignature.h

@@ -69,8 +69,8 @@ class RootSignatureParser {
   bool parseDescriptorTable();
   bool parseDescriptorTableClause();
 
-  /// Each unique ParamType will have a custom parse method defined that we can
-  /// use to invoke the parameters.
+  /// Each unique ParamType will have a custom parse method defined that can be
+  /// invoked to set a value to the referenced paramtype.
   ///
   /// This function will switch on the ParamType using std::visit and dispatch
   /// onto the corresponding parse method
@@ -86,7 +86,7 @@ class RootSignatureParser {
   ///    TokenKind::kw_space, &Clause.Space
   ///  };
   ///  SmallDenseSet<TokenKind> Mandatory = {
-  ///    TokenKind::kw_numDescriptors
+  ///    TokenKind::bReg
   ///  };
   ///
   /// We can read it is as:

clang/lib/Parse/ParseHLSLRootSignature.cpp

@@ -210,6 +210,8 @@ bool RootSignatureParser::parseRegister(Register *Register) {
       "Expects to only be invoked starting at given keyword");
 
   switch (CurToken.Kind) {
+  default:
+    llvm_unreachable("Switch for consumed token was not provided");
   case TokenKind::bReg:
     Register->ViewType = RegisterType::BReg;
     break;
@@ -222,8 +224,6 @@ bool RootSignatureParser::parseRegister(Register *Register) {
   case TokenKind::sReg:
     Register->ViewType = RegisterType::SReg;
     break;
-  default:
-    break; // Unreachable given Try + assert pattern
   }
 
   if (handleUIntLiteral(&Register->Number))