[flang] Update builder.create<T> to T::create

Author: JDPailleux

flang/lib/Optimizer/Builder/IntrinsicCall.cpp

@@ -3684,14 +3684,13 @@ void IntrinsicLibrary::genCoBroadcast(llvm::ArrayRef<fir::ExtendedValue> args) {
   mlir::Value sourceImage = fir::getBase(args[1]);
   mlir::Value status =
       isStaticallyAbsent(args[2])
-          ? builder
-                .create<fir::AbsentOp>(loc,
-                                       builder.getRefType(builder.getI32Type()))
+          ? fir::AbsentOp::create(builder, loc,
+                                  builder.getRefType(builder.getI32Type()))
                 .getResult()
           : fir::getBase(args[2]);
   mlir::Value errmsg =
       isStaticallyAbsent(args[3])
-          ? builder.create<fir::AbsentOp>(loc, PRIF_ERRMSG_TYPE).getResult()
+          ? fir::AbsentOp::create(builder, loc, PRIF_ERRMSG_TYPE).getResult()
           : fir::getBase(args[3]);
   fir::runtime::genCoBroadcast(builder, loc, fir::getBase(args[0]), sourceImage,
                                status, errmsg);
@@ -3702,16 +3701,16 @@ void IntrinsicLibrary::genCoMax(llvm::ArrayRef<fir::ExtendedValue> args) {
   checkCoarrayEnabled();
   assert(args.size() == 4);
   mlir::Value refNone =
-      builder
-          .create<fir::AbsentOp>(loc, builder.getRefType(builder.getI32Type()))
+      fir::AbsentOp::create(builder, loc,
+                            builder.getRefType(builder.getI32Type()))
           .getResult();
   mlir::Value resultImage =
       isStaticallyAbsent(args[1]) ? refNone : fir::getBase(args[1]);
   mlir::Value status =
       isStaticallyAbsent(args[2]) ? refNone : fir::getBase(args[2]);
   mlir::Value errmsg =
       isStaticallyAbsent(args[3])
-          ? builder.create<fir::AbsentOp>(loc, PRIF_ERRMSG_TYPE).getResult()
+          ? fir::AbsentOp::create(builder, loc, PRIF_ERRMSG_TYPE).getResult()
           : fir::getBase(args[3]);
   fir::runtime::genCoMax(builder, loc, fir::getBase(args[0]), resultImage,
                          status, errmsg);
@@ -3722,16 +3721,16 @@ void IntrinsicLibrary::genCoMin(llvm::ArrayRef<fir::ExtendedValue> args) {
   checkCoarrayEnabled();
   assert(args.size() == 4);
   mlir::Value refNone =
-      builder
-          .create<fir::AbsentOp>(loc, builder.getRefType(builder.getI32Type()))
+      fir::AbsentOp::create(builder, loc,
+                            builder.getRefType(builder.getI32Type()))
           .getResult();
   mlir::Value resultImage =
       isStaticallyAbsent(args[1]) ? refNone : fir::getBase(args[1]);
   mlir::Value status =
       isStaticallyAbsent(args[2]) ? refNone : fir::getBase(args[2]);
   mlir::Value errmsg =
       isStaticallyAbsent(args[3])
-          ? builder.create<fir::AbsentOp>(loc, PRIF_ERRMSG_TYPE).getResult()
+          ? fir::AbsentOp::create(builder, loc, PRIF_ERRMSG_TYPE).getResult()
           : fir::getBase(args[3]);
   fir::runtime::genCoMin(builder, loc, fir::getBase(args[0]), resultImage,
                          status, errmsg);
@@ -3742,16 +3741,16 @@ void IntrinsicLibrary::genCoSum(llvm::ArrayRef<fir::ExtendedValue> args) {
   checkCoarrayEnabled();
   assert(args.size() == 4);
   mlir::Value absentInt =
-      builder
-          .create<fir::AbsentOp>(loc, builder.getRefType(builder.getI32Type()))
+      fir::AbsentOp::create(builder, loc,
+                            builder.getRefType(builder.getI32Type()))
           .getResult();
   mlir::Value resultImage =
       isStaticallyAbsent(args[1]) ? absentInt : fir::getBase(args[1]);
   mlir::Value status =
       isStaticallyAbsent(args[2]) ? absentInt : fir::getBase(args[2]);
   mlir::Value errmsg =
       isStaticallyAbsent(args[3])
-          ? builder.create<fir::AbsentOp>(loc, PRIF_ERRMSG_TYPE).getResult()
+          ? fir::AbsentOp::create(builder, loc, PRIF_ERRMSG_TYPE).getResult()
           : fir::getBase(args[3]);
   fir::runtime::genCoSum(builder, loc, fir::getBase(args[0]), resultImage,
                          status, errmsg);

flang/lib/Optimizer/Builder/Runtime/Coarray.cpp

@@ -26,7 +26,7 @@ genErrmsgPRIF(fir::FirOpBuilder &builder, mlir::Location loc,
               mlir::Value errmsg) {
   bool isAllocatableErrmsg = fir::isAllocatableType(errmsg.getType());
 
-  mlir::Value absent = builder.create<fir::AbsentOp>(loc, PRIF_ERRMSG_TYPE);
+  mlir::Value absent = fir::AbsentOp::create(builder, loc, PRIF_ERRMSG_TYPE);
   mlir::Value errMsg = isAllocatableErrmsg ? absent : errmsg;
   mlir::Value errMsgAlloc = isAllocatableErrmsg ? errmsg : absent;
   return {errMsg, errMsgAlloc};
@@ -42,8 +42,8 @@ mlir::Value fir::runtime::genInitCoarray(fir::FirOpBuilder &builder,
       builder.createFunction(loc, PRIFNAME_SUB("init"), ftype);
   llvm::SmallVector<mlir::Value> args =
       fir::runtime::createArguments(builder, loc, ftype, result);
-  builder.create<fir::CallOp>(loc, funcOp, args);
-  return builder.create<fir::LoadOp>(loc, result);
+  fir::CallOp::create(builder, loc, funcOp, args);
+  return fir::LoadOp::create(builder, loc, result);
 }
 
 /// Generate Call to runtime prif_num_images
@@ -56,8 +56,8 @@ mlir::Value fir::runtime::getNumImages(fir::FirOpBuilder &builder,
       builder.createFunction(loc, PRIFNAME_SUB("num_images"), ftype);
   llvm::SmallVector<mlir::Value> args =
       fir::runtime::createArguments(builder, loc, ftype, result);
-  builder.create<fir::CallOp>(loc, funcOp, args);
-  return builder.create<fir::LoadOp>(loc, result);
+  fir::CallOp::create(builder, loc, funcOp, args);
+  return fir::LoadOp::create(builder, loc, result);
 }
 
 /// Generate Call to runtime prif_num_images_with_{team|team_number}
@@ -81,8 +81,8 @@ mlir::Value fir::runtime::getNumImagesWithTeam(fir::FirOpBuilder &builder,
     team = builder.createBox(loc, team);
   llvm::SmallVector<mlir::Value> args =
       fir::runtime::createArguments(builder, loc, ftype, team, result);
-  builder.create<fir::CallOp>(loc, funcOp, args);
-  return builder.create<fir::LoadOp>(loc, result);
+  fir::CallOp::create(builder, loc, funcOp, args);
+  return fir::LoadOp::create(builder, loc, result);
 }
 
 /// Generate Call to runtime prif_this_image_no_coarray
@@ -96,11 +96,11 @@ mlir::Value fir::runtime::getThisImage(fir::FirOpBuilder &builder,
 
   mlir::Value result = builder.createTemporary(loc, builder.getI32Type());
   mlir::Value teamArg =
-      !team ? builder.create<fir::AbsentOp>(loc, boxTy) : team;
+      !team ? fir::AbsentOp::create(builder, loc, boxTy) : team;
   llvm::SmallVector<mlir::Value> args =
       fir::runtime::createArguments(builder, loc, ftype, teamArg, result);
-  builder.create<fir::CallOp>(loc, funcOp, args);
-  return builder.create<fir::LoadOp>(loc, result);
+  fir::CallOp::create(builder, loc, funcOp, args);
+  return fir::LoadOp::create(builder, loc, result);
 }
 
 /// Generate call to collective subroutines except co_reduce