code review feedback - add arg comments, use Sema for name lookup

Author: hekota

clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp

@@ -600,8 +600,11 @@ BuiltinTypeMethodBuilder &BuiltinTypeMethodBuilder::returnValue(T ReturnValue) {
     CXXConstructorDecl *CD = lookupCopyConstructor(Ty);
     assert(CD && "no copy constructor found");
     ReturnValueExpr = CXXConstructExpr::Create(
-        AST, Ty, SourceLocation(), CD, false, {ICE}, false, false, false, false,
-        CXXConstructionKind::Complete, SourceRange());
+        AST, Ty, SourceLocation(), CD, /*Elidable=*/false, {ICE},
+        /*HadMultipleCandidates=*/false, /*ListInitialization=*/false,
+        /*StdInitListInitialization=*/false,
+        /*ZeroInitListInitialization=*/false, CXXConstructionKind::Complete,
+        SourceRange());
   }
   StmtsList.push_back(
       ReturnStmt::Create(AST, SourceLocation(), ReturnValueExpr, nullptr));

clang/lib/Sema/SemaHLSL.cpp

@@ -1212,12 +1212,13 @@ struct PerVisibilityBindingChecker {
   }
 };
 
-static CXXMethodDecl *lookupMethod(CXXRecordDecl *Record, StringRef Name,
-                                   StorageClass SC = SC_None) {
-  for (auto *Method : Record->methods())
-    if (Method->getStorageClass() == SC && Method->getName() == Name)
-      return Method;
-  return nullptr;
+static CXXMethodDecl *lookupMethod(Sema &S, CXXRecordDecl *RecordDecl,
+                                   StringRef Name, SourceLocation Loc) {
+  DeclarationName DeclName(&S.getASTContext().Idents.get(Name));
+  LookupResult Result(S, DeclName, Loc, Sema::LookupMemberName);
+  if (!S.LookupQualifiedName(Result, static_cast<DeclContext *>(RecordDecl)))
+    return nullptr;
+  return cast<CXXMethodDecl>(Result.getFoundDecl());
 }
 
 } // end anonymous namespace
@@ -3825,15 +3826,17 @@ bool SemaHLSL::initGlobalResourceDecl(VarDecl *VD) {
 
   if (RegisterSlot.has_value()) {
     // The resource has explicit binding.
-    CreateMethod = lookupMethod(ResourceDecl, "__createFromBinding", SC_Static);
+    CreateMethod = lookupMethod(SemaRef, ResourceDecl, "__createFromBinding",
+                                VD->getLocation());
     IntegerLiteral *RegSlot = IntegerLiteral::Create(
         AST, llvm::APInt(UIntTySize, RegisterSlot.value()), AST.UnsignedIntTy,
         SourceLocation());
     Args.push_back(RegSlot);
   } else {
     // The resource has implicit binding.
     CreateMethod =
-        lookupMethod(ResourceDecl, "__createFromImplicitBinding", SC_Static);
+        lookupMethod(SemaRef, ResourceDecl, "__createFromImplicitBinding",
+                     VD->getLocation());
     uint32_t OrderID = (RBA && RBA->hasImplicitBindingOrderID())
                            ? RBA->getImplicitBindingOrderID()
                            : getNextImplicitBindingOrderID();